Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved_coverage for output_engine #603

Merged
merged 4 commits into from Apr 28, 2020
Merged

improved_coverage for output_engine #603

merged 4 commits into from Apr 28, 2020

Conversation

SinghHrmn
Copy link
Contributor

@SinghHrmn SinghHrmn commented Apr 28, 2020

Changes

  • changed filename generation function in OutputEngine.py. Changed : to - because : is not a valid name character in Windows. And was the reason my tests were failing in windows.
  • Improved Coverage for cve_bin_tool/OutputEngine.py (98% from 68.24%)

@codecov-io
Copy link

Codecov Report

Merging #603 into master will decrease coverage by 8.58%.
The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
- Coverage   84.20%   75.61%   -8.59%     
==========================================
  Files          63       63              
  Lines        2494     2547      +53     
  Branches      497      505       +8     
==========================================
- Hits         2100     1926     -174     
- Misses        270      460     +190     
- Partials      124      161      +37     
Flag Coverage Δ
#longtests 75.61% <98.14%> (-8.59%) ⬇️
Impacted Files Coverage Δ
test/test_output_engine.py 98.82% <98.11%> (-1.18%) ⬇️
cve_bin_tool/OutputEngine.py 97.64% <100.00%> (+29.41%) ⬆️
cve_bin_tool/cvedb.py 52.52% <0.00%> (-30.98%) ⬇️
test/test_json.py 60.60% <0.00%> (-30.31%) ⬇️
cve_bin_tool/checkers/cups.py 72.22% <0.00%> (-27.78%) ⬇️
cve_bin_tool/checkers/rsyslog.py 72.22% <0.00%> (-27.78%) ⬇️
cve_bin_tool/checkers/wireshark.py 72.22% <0.00%> (-27.78%) ⬇️
cve_bin_tool/checkers/postgresql.py 72.22% <0.00%> (-27.78%) ⬇️
cve_bin_tool/checkers/strongswan.py 72.22% <0.00%> (-27.78%) ⬇️
cve_bin_tool/checkers/xml2.py 54.90% <0.00%> (-27.46%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5d4ce...2fabd89. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Every time I opened the coverage reports, I thought "huh, should file a bug about OutputEngine coverage" so I'm very glad to see it improved.

@terriko
Copy link
Contributor

terriko commented Apr 28, 2020

Although it is amusing that codecov is complaining. I really need to understand how to get it to give us meaningful data; apparently my last intuition wasn't correct.

@terriko terriko merged commit 8e29144 into intel:master Apr 28, 2020
@SinghHrmn SinghHrmn deleted the output_engine branch April 29, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants