Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Final run of integration tests does not fail CI if tests fail #358

Closed
pdxjohnny opened this issue Jan 28, 2020 · 0 comments
Closed

ci: Final run of integration tests does not fail CI if tests fail #358

pdxjohnny opened this issue Jan 28, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers kind/infrastructure CI related issues p0 Critical Priority tXS Esitmated Time To Complete: Extra Short

Comments

@pdxjohnny
Copy link
Member

dffml/.ci/run.sh

Lines 69 to 74 in 07e6082

# Run with coverage
"${PYTHON}" -m coverage run setup.py test 2>&1 | tee "${check_skips}"
"${PYTHON}" -m coverage report -m
# Fail if any tests were skipped
grep -v -q -E '(skipped=.*)' "${check_skips}"

This is the final run of the CI tests for the main package (dffml, the tests in tests/)

It's meant to ensure that no integration tests are skipped. However, it forgets to check if any tests errored. We need the grep to exit non-zero if there were any errors.

@pdxjohnny pdxjohnny added bug Something isn't working kind/infrastructure CI related issues p0 Critical Priority tXS Esitmated Time To Complete: Extra Short labels Jan 28, 2020
@pdxjohnny pdxjohnny added this to the 0.3.3 Alpha Release milestone Jan 28, 2020
@pdxjohnny pdxjohnny added the good first issue Good for newcomers label Feb 8, 2020
@pdxjohnny pdxjohnny modified the milestones: 0.3.4 Alpha Release, 0.3.5 Feb 29, 2020
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 4, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 4, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 4, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 4, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 5, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 6, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 6, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 6, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 6, 2020
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit to pdxjohnny/dffml that referenced this issue Mar 11, 2022
Fixes: intel#358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
pdxjohnny added a commit that referenced this issue Mar 12, 2022
Fixes: #358

Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers kind/infrastructure CI related issues p0 Critical Priority tXS Esitmated Time To Complete: Extra Short
Projects
None yet
Development

No branches or pull requests

1 participant