Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.1] Fix the Format in the SDA-BERT/DE-NAS BERT/ViT/HF Demos #285

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

tianyil1
Copy link
Contributor

@tianyil1 tianyil1 commented Apr 25, 2023

What changes were proposed in this pull request?

This PR is used to fix the typos and formats in the SDA-BERT/DE-NAS BERT/ViT/HF demo.

Why are the changes needed?

Fix the typos and formats.

How was this patch tested?

The unit test of this PR is covered by the CI/CD test of SDA and DE-NAS.

@github-actions
Copy link

Thanks for opening a pull request!

Please open an issue for this pull request on Github Issues as well.

https://github.com/intel/e2eAIOK/issues

Pull Request Name format: [${VERSION_ID}][ISSUE-${ISSUES_ID}] ${detailed message}
ex: [v1.1][ISSUE-190] Add PR to issue link

@tianyil1 tianyil1 changed the title [v1.1] Fix the Typos in the SDA BERT Demo [v1.1] Fix the Format in the SDA-BERT/DE-NAS BERT/ViT/HF Demos Apr 26, 2023
@xuechendi
Copy link
Contributor

@tianyil1 , is your Huggingface demo completed? I think we are planning to add an example showing how integrating with huggingface training, but looks like this part is still WIP?

@tianyil1
Copy link
Contributor Author

@tianyil1 , is your Huggingface demo completed? I think we are planning to add an example showing how integrating with huggingface training, but looks like this part is still WIP?

I have added the training part and its corresponding configuration for the DE-NAS HF demo. Please check it. @xuechendi

Copy link
Contributor

@xuechendi xuechendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuechendi xuechendi merged commit b3c5cdf into intel:main Apr 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants