Upgrade ambient-map to Polymer3.0+LitElement+MWC #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchris
reviewed
Nov 2, 2018
ambient-map/index.html
Outdated
| <body class="fullbleed"> | ||
| <script type="module" src="src/ambientmap-app.js"></script> | ||
| </head> | ||
| <body class="fullbleed"> |
kenchris
reviewed
Nov 2, 2018
ambient-map/src/ambientmap-app.js
Outdated
| this.latitude = 60.1699; | ||
| this.longitude = 24.9384; | ||
| this.mapApiKey = location.origin === 'https://ambientmap.appspot.com' || location.origin === 'https://intel.github.io' ? 'AIzaSyCR59cBBxaiINBUEbdmUVHYs8CV8jtEDTw' : 'DEADBEEF59cBBxaiINBUEbdmUVHYs8CV8jtEDTw'; | ||
| this.infoText = "Welcome to Ambitent Map demo! This web application demonstrates how Ambient light sensor can be used to control style of a map widget. When ambient illuminance level is less than 10 lumen, night mode style will be used."; |
There was a problem hiding this comment.
I think we should just inline these
kenchris
reviewed
Nov 2, 2018
ambient-map/src/ambientmap-app.js
Outdated
| this.infoText = "Welcome to Ambitent Map demo! This web application demonstrates how Ambient light sensor can be used to control style of a map widget. When ambient illuminance level is less than 10 lumen, night mode style will be used."; | ||
| this.styles = []; | ||
| this.nightStyles = [ | ||
| {elementType: 'geometry', |
kenchris
reviewed
Nov 2, 2018
ambient-map/src/ambientmap-app.js
Outdated
| navigator.geolocation.getCurrentPosition((pos) => { | ||
| this.latitude = pos.coords.latitude; | ||
| this.longitude = pos.coords.longitude; | ||
| this.requestUpdate('latitude'); |
There was a problem hiding this comment.
Better names these properties (static get properties()) when they update often. requestUpdate is mostly needed when you deal with arrays etc
kenchris
reviewed
Nov 2, 2018
ambient-map/src/ambientmap-app.js
Outdated
| } | ||
|
|
||
| openInfoDialog() { | ||
| this.infoDialog = this.shadowRoot.querySelector('#infoDialog'); |
There was a problem hiding this comment.
This should be done in firstUpdated (meaning filled shadow root exists)
kenchris
reviewed
Nov 2, 2018
| } | ||
| </style> | ||
|
|
||
| <google-map id="mapElement" latitude="${this.latitude}" longitude="${this.longitude}" zoom="14" min-zoom="9" max-zoom="20" styles="${this.styles}" language="en" api-key="${this.mapApiKey}"> |
There was a problem hiding this comment.
These update often, so better use property setters than attribtute setters... this .latitute=
- Delete unused CSS class - Delete infoText attribtute - Add latitude and longitude properties - Get paper-dialog element in firstUpdated() - Add autofocus to close button - Modify JSON format
|
@kenchris, many thanks for your review! I just submit a new commit to address your comments, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenchris, @rakuco, PTAL.