-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for cmake 2.8 #1
Comments
Fixes intel#1 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Thanks for the feedback.. I see the value in your proposed change. As this affects media-driver builds as well, we need to discuss this further with internal committee before pursuing this change. I will get back on this soon. |
v1: require 2.8.12 as the actuallu minimum tested version. Fixes intel#1 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
v1: require 2.8.12 as the actuall minimum tested version. v2: fix build out of media-driver environment. (Artie) Fixes intel#1 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
We cannot provide compatibility with any version lower than 3.5 due to clients requirements. GmmLib clients are using certain features from 3.5+ cmake version, and because GmmLib is statically built as part of those projects, it may break their builds. Hence we cannot support this PR. |
Some Linux distributions, especially server distributions, still has older cmake versions than 3.5 by default. Cent OS 7.4 is an example:
Yocto is another example:
Please, provide compatibility with older versions of cmake starting from 2.8 to extend Linux distributions coverage. Mind that currently gmmlib does not actually has dependency from cmake 3.5 and can be built with cmake 2.8 just fine.
The text was updated successfully, but these errors were encountered: