Add option do discard test suite #9
Conversation
Setup a new option to avoid test suite run after install in order to allow cross compilation. Append `-DTEST_SUITE_RUN=OFF` to the **CMake** command line.
ghost
mentioned this pull request
* option renamed option renamed * option renamed option renamed
|
Hi, Sorry for delayed response on this. I have a question on your proposed change. what is the specific reason that you want to disable ULT tests execution? Thanks. |
|
The main idea behind this proposal is to allow cross compilation. |
| @@ -1,2 +1,7 @@ | |||
| cmake_minimum_required (VERSION 3.1 FATAL_ERROR) | |||
|
|
|||
| if (NOT DEFINED MEDIA_RUN_TEST_SUITE) | |||
There was a problem hiding this comment.
Because GmmLib is generic library between Intel Media driver and Intel Compute-runtime, I will keep the naming generic as RUN_TEST_SUITE.
There was a problem hiding this comment.
ok, ftr the name was a request from Media driver devs.
| @@ -544,4 +544,7 @@ if(ARCH EQUAL 32) | |||
| endif() | |||
| endif() | |||
|
|
|||
| add_subdirectory(ULT) | |||
| if(MEDIA_RUN_TEST_SUITE) | |||
There was a problem hiding this comment.
If in case someone build GmmLib separately from Source/GmmLib, this check will fail and skip ULT run, so better to modify this as
if(NOT DEFINED RUN_TEST_SUITE OR RUN_TEST_SUITE)
There was a problem hiding this comment.
If not defined in the first place, this option was setup to ON by default. See the top level CMakelists.
There was a problem hiding this comment.
Yes, but someone can skip running it from top level cmake and instead start the build from Source/GmmLib, which is possible, in that case it was skipping the ULT unnecessarily.
|
This change has been merged - f5ded73. |
Setup a new option to avoid test suite run after install in order to allow cross compilation.
Append
-DTEST_SUITE_RUN=OFFto the CMake command line.See intel/media-driver#135
intel/media-driver#108