ReduceMod optimization #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboemer
suggested changes
Oct 8, 2021
fboemer
approved these changes
Oct 8, 2021
GelilaSeifu
force-pushed
the
gseifu/opt-ReduceMod
branch
from
0c0ae4b
to
1f14360
Compare
skmono
approved these changes
Oct 9, 2021
GelilaSeifu
force-pushed
the
gseifu/opt-ReduceMod
branch
from
1f14360
to
0bbd420
Compare
fboemer
pushed a commit
that referenced
this pull request
Nov 8, 2021
* optimize modular reduction * remove MinTime * update condition * add unit test * test algorithm 2 barrett reduction * use different optimization for reduce mod based on input size * add more test and benchmark * update include * fix formatting * fix formatting * rename arg, better perf * fix windows build * fix IFMA52 unit-tests * fix debug benchmark * avoid unused error * update modulo * update test * simplify test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Barrett Reduction for output_mod_factor=2 and BitShift=52/64. See details at https://jiratest.idoc.intel.com/browse/GLADE-12