A question regarding the code

[shlyakpavel]

Could someone please explain the magic here?

hyperscan/util/ng_corpus_generator.cpp

Lines 486 to 488 in 4cebdaa

	if (c >= UNICODE_SURROGATE_MIN) {
	c =+ UNICODE_SURROGATE_MAX + 1;
	}

I'm especially interested in =+ stuff

[xiangwang1]

I think this code aims to skip code points between UNICODE_SURROGATE_MIN and UNICODE_SURROGATE_MAX which are not useful. Adding UNICODE_SURROGATE_MAX is probably the most convenient and concise way.

[shlyakpavel]

Adding UNICODE_SURROGATE_MAX

Would look like c += UNICODE_SURROGATE_MAX + 1;
The present code is setting c to UNICODE_SURROGATE_MAX + 1, which is equal to
c = UNICODE_SURROGATE_MAX + 1.
I would personally prefer to change to either to += or to = (up to whatever original author meant) to avoid confusions.

[xiangwang1]

Thanks, we'll change it.

[shlyakpavel]

@xiangwang1 it looks like the issue is still not resolved

[shlyakpavel]

@xiangwang1 the issue is still not resolved

[fatchanghao]

updated on "develop" branch.