This repository has been archived by the owner on Dec 14, 2022. It is now read-only.
Add Symbol.toStringTag for each class #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of each class with string
| @@ -101,4 +106,8 @@ Napi::Value Blob::Size(const Napi::CallbackInfo& info) { | |||
| return Napi::Number::New(env, actual_->size()); | |||
| } | |||
|
|
|||
| Napi::Value Blob::toStringTag(const Napi::CallbackInfo& info) { | |||
| return Napi::String::From(info.Env(), "Blob"); | |||
There was a problem hiding this comment.
what about adding more information? for example bytesize:
"Blob of N byte" or something like this
There was a problem hiding this comment.
I do not understand your comment clearly. Do you mean that we should an object that contains more information?
There was a problem hiding this comment.
Ok. You cam share your ideas for related information in this comment. I will try to add them in this PR in next few days. Thanks.
| @@ -198,4 +202,8 @@ Napi::Value Core::GetAvailableDevices(const Napi::CallbackInfo& info) { | |||
| return available_devices; | |||
| } | |||
|
|
|||
| Napi::Value Core::toStringTag(const Napi::CallbackInfo& info) { | |||
| return Napi::String::From(info.Env(), "Core"); | |||
There was a problem hiding this comment.
I suggest "OpenVINO Inference Engine Core"
There was a problem hiding this comment.
It is easy to finish it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can fix all the failed cases caused by using
Stringto check class.The sample looks like:
This case is failed before the PR. And the PR fixes all similar failed test cases.