Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image name validation fails when registry hostname:port is specified #605

Closed
mythi opened this issue Mar 29, 2021 · 1 comment · Fixed by #608 or #648
Closed

image name validation fails when registry hostname:port is specified #605

mythi opened this issue Mar 29, 2021 · 1 comment · Fixed by #608 or #648
Labels
bug Something isn't working operator Device operator related issue

Comments

@mythi
Copy link
Contributor

mythi commented Mar 29, 2021 •
edited

the validation of a valid image entry fails:
localhost:8080/intel-sgx-plugin:1.2.3
@mythi mythi added bug Something isn't working operator Device operator related issue labels Mar 29, 2021
ozhuraki added a commit to ozhuraki/intel-device-plugins-for-kubernetes that referenced this issue Mar 30, 2021
@ozhuraki
webhook_common: Support domains with a custom port in the image string
63507e0 
In order to support domains with a custom port, parse the image version
after the domain part.

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@ozhuraki ozhuraki mentioned this issue Mar 30, 2021
Merged
ozhuraki added a commit to ozhuraki/intel-device-plugins-for-kubernetes that referenced this issue Mar 30, 2021
@ozhuraki
webhook_common: Support domains with a custom port in the image string
229dca5 
In order to support domains with a custom port, parse the image version
after the domain part.

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
ozhuraki added a commit to ozhuraki/intel-device-plugins-for-kubernetes that referenced this issue Mar 30, 2021
@ozhuraki
webhook_common: Extract only relevant parts for the validation
7d40758 
Since we currently validate only the image name and the tag,
ignore registry, vendor and extract only relevant parts.

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@mythi mythi reopened this Jun 8, 2021
@mythi
Copy link
Contributor Author

mythi commented Jun 8, 2021

@ozhuraki can you help re-checking this. it fails with qat webhook.

ozhuraki added a commit to ozhuraki/intel-device-plugins-for-kubernetes that referenced this issue Jun 10, 2021
@ozhuraki
qatdeviceplugin_webhook: Extract only relevant parts for the validation
3d27f3c 
Since we currently validate only the image name and the tag,
ignore registry, vendor and extract only relevant parts.

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@ozhuraki ozhuraki mentioned this issue Jun 10, 2021
Merged
ozhuraki added a commit to ozhuraki/intel-device-plugins-for-kubernetes that referenced this issue Jun 14, 2021
@ozhuraki
qatdeviceplugin_webhook: Extract only relevant parts for the validation
39d96f5 
Since we currently validate only the image name and the tag,
ignore registry, vendor and extract only relevant parts.

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
ozhuraki added a commit to ozhuraki/intel-device-plugins-for-kubernetes that referenced this issue Jun 14, 2021
@ozhuraki
qatdeviceplugin_webhook: Reuse common function for the image name val…
748863a 
…idation

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
bart0sh pushed a commit to bart0sh/intel-device-plugins-for-kubernetes that referenced this issue Jun 17, 2021
@ozhuraki @bart0sh
qatdeviceplugin_webhook: Reuse common function for the image name val…
7bad583 
…idation

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
bart0sh pushed a commit to bart0sh/intel-device-plugins-for-kubernetes that referenced this issue Dec 2, 2021
@ozhuraki @bart0sh
webhook_common: Extract only relevant parts for the validation
a16cd42 
Since we currently validate only the image name and the tag,
ignore registry, vendor and extract only relevant parts.

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
bart0sh pushed a commit to bart0sh/intel-device-plugins-for-kubernetes that referenced this issue Dec 2, 2021
@ozhuraki @bart0sh
qatdeviceplugin_webhook: Reuse common function for the image name val…
024439a 
…idation

Closes intel#605

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working operator Device operator related issue
Projects
None yet
Milestone
No milestone
1 participant
@mythi