Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhooks: stop handling Pod updates #1484

Merged
merged 1 commit into from
Aug 15, 2023
Merged

webhooks: stop handling Pod updates #1484

merged 1 commit into from
Aug 15, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Jul 25, 2023

FPGA and SGX webhooks mutate container resources which are immutable. Therefore, stop processing pod updates and act on creation only.

Fixes: #1357

@codecov-commenter
Copy link

Codecov Report

Merging #1484 (725dda6) into main (e57723c) will not change coverage.
The diff coverage is n/a.

❗ Current head 725dda6 differs from pull request most recent head 5922f6c. Consider uploading reports for the commit 5922f6c to get more accurate results

@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files          43       43           
  Lines        4884     4884           
=======================================
  Hits         2444     2444           
  Misses       2301     2301           
  Partials      139      139           
Files Changed Coverage Δ
pkg/fpgacontroller/patcher/patchermanager.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

FPGA and SGX webhooks mutate container resources which
are immutable. Therefore, stop processing pod updates
and act on creation only.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi mythi marked this pull request as ready for review August 14, 2023 12:26
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkatila tkatila merged commit 9d8afa3 into intel:main Aug 15, 2023
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods stuck in terminating state
4 participants