Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qat: update README #1535

Merged
merged 1 commit into from
Sep 19, 2023
Merged

qat: update README #1535

merged 1 commit into from
Sep 19, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Sep 14, 2023

The documentation needs clarifications to how QAT Gen4 SW differs from older platfoms:

  • only upstream driver is available and due to this, the -mode parameter is now deprecated
  • the QAT VF services are configurable and thus the resource names differ

Fixes: #1528

@mythi
Copy link
Contributor Author

mythi commented Sep 14, 2023

@chaitanya1731 PTAL

The documentation needs clarifications to how QAT Gen4 SW differs from
older platfoms:

- only upstream driver is available and due to this, the -mode parameter
  is now deprecated
- the QAT VF services are configurable and thus the resource names
  differ

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1535 (b1abdc3) into main (ba3ded1) will not change coverage.
The diff coverage is n/a.

❗ Current head b1abdc3 differs from pull request most recent head 06f1db9. Consider uploading reports for the commit 06f1db9 to get more accurate results

@@           Coverage Diff           @@
##             main    #1535   +/-   ##
=======================================
  Coverage   49.58%   49.58%           
=======================================
  Files          42       42           
  Lines        4917     4917           
=======================================
  Hits         2438     2438           
  Misses       2339     2339           
  Partials      140      140           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I'm not in the reviewers, this looks good to me.

@mythi
Copy link
Contributor Author

mythi commented Sep 18, 2023

@hj-johannes-lee ping

@hj-johannes-lee hj-johannes-lee merged commit 0889ca1 into intel:main Sep 19, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation: QAT plugin documentation requires some revisions
4 participants