fpga: move GetAPIVersion call out of NewPort and NewFME #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart0sh
force-pushed
the
PR0094-move-GetAPIVersion-out-of-NewPort
branch
2 times, most recently
from
8a2b966
to
0b6b247
Compare
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
+ Coverage 56.41% 56.70% +0.29%
==========================================
Files 30 30
Lines 2035 2028 -7
==========================================
+ Hits 1148 1150 +2
+ Misses 816 807 -9
Partials 71 71
Continue to review full report at Codecov.
|
bart0sh
force-pushed
the
PR0094-move-GetAPIVersion-out-of-NewPort
branch
from
0b6b247
to
fbccd20
Compare
This call is implemented by calling ioctl, which raises "open /dev/intel-fpga-port.X: operation not permitted" error when called inside unprivileged container. This breaks FPGA plugin. Calling this API from fpga_tool is still OK, so moving calls there should fix the issue. Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
bart0sh
force-pushed
the
PR0094-move-GetAPIVersion-out-of-NewPort
branch
from
fbccd20
to
2c73e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call is implemented by calling ioctl, which raises
"open /dev/intel-fpga-port.X: operation not permitted" when
called inside unprivileged container.
This breaks FPGA plugin.
Calling this API from fpga_tool is still OK, so
moving calls there should fix the issue.