enable getPreferredAllocation #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 57.12% 57.24% +0.12%
==========================================
Files 31 31
Lines 2120 2119 -1
==========================================
+ Hits 1211 1213 +2
+ Misses 839 837 -2
+ Partials 70 69 -1
Continue to review full report at Codecov.
|
rojkov
reviewed
Jan 5, 2021
pkg/deviceplugin/server.go
Outdated
Comment on lines
82
to
85
| return &pluginapi.DevicePluginOptions{ | ||
| PreStartRequired: srv.preStartContainer != nil, | ||
| GetPreferredAllocationAvailable: false, | ||
| GetPreferredAllocationAvailable: srv.getPreferredAllocation != nil, | ||
| }, nil |
There was a problem hiding this comment.
I'd rather put this struct creation into a private method with narrow interface like func (srv *server) getDevicePluginOptions() *pluginapi.DevicePluginOptions and use it here and also inside registerWithKublet().
This way we wouldn't need to create and immediately throw away the context.
Then we can drop options from registerWithKublet()'s signature.
The option was left to false, this fixes it. Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
rojkov
approved these changes
Jan 5, 2021
bart0sh
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option was left to false, this fixes it.
Signed-off-by: Ukri Niemimuukko ukri.niemimuukko@intel.com