Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added implementation of EPC extended resource advertiser #550

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

dmitsh
Copy link
Contributor

@dmitsh dmitsh commented Jan 28, 2021

Signed-off-by: Dmitry Shmulevich dmitry.shmulevich@gmail.com

Closes: #457

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitsh thanks!

I added a couple of thoughts to bettter integrate this with the existing functionality. What do you think?

cmd/sgx_epc_extendedresource/main.go Outdated Show resolved Hide resolved
deployments/sgx_epc_extendedresource/daemonset.yml Outdated Show resolved Hide resolved
@dmitsh dmitsh requested a review from kad as a code owner January 30, 2021 06:21
@dmitsh dmitsh requested a review from mythi January 30, 2021 06:23
@kad
Copy link
Member

kad commented Feb 1, 2021

Generally looks ok, but please squash commits like "typos"/"minor"

@dmitsh
Copy link
Contributor Author

dmitsh commented Feb 2, 2021

Generally looks ok, but please squash commits like "typos"/"minor"

done

Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com>
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mythi mythi merged commit 7561501 into intel:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SGX Extended resources
4 participants