Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: add DSA support #553

Merged
merged 2 commits into from
Feb 9, 2021
Merged

operator: add DSA support #553

merged 2 commits into from
Feb 9, 2021

Conversation

bart0sh
Copy link
Member

@bart0sh bart0sh commented Feb 2, 2021 •
edited by mythi

Closes: #443

@bart0sh bart0sh force-pushed the PR0103-implement-dsa-operator branch 2 times, most recently from b449870 to 6507177 Compare February 2, 2021 17:00
@bart0sh bart0sh marked this pull request as draft February 2, 2021 17:02
mythi
mythi reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bart0sh!

can you add test/envtest code too

pkg/controllers/dsa/controller.go Outdated Show resolved Hide resolved
pkg/controllers/dsa/controller.go Outdated Show resolved Hide resolved
@bart0sh bart0sh force-pushed the PR0103-implement-dsa-operator branch 7 times, most recently from 3a02236 to dfa568e Compare February 9, 2021 00:04
@bart0sh
operator: add DSA support
884f8e3 
Fixes: intel#443

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
@bart0sh
operator: DSA: [re]generated files
dac99ad 
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
@bart0sh bart0sh force-pushed the PR0103-implement-dsa-operator branch from dfa568e to dac99ad Compare February 9, 2021 00:13
@bart0sh bart0sh marked this pull request as ready for review February 9, 2021 00:38
rojkov
rojkov approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@rojkov rojkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mythi mythi merged commit 965936d into intel:master Feb 9, 2021
@bart0sh bart0sh deleted the PR0103-implement-dsa-operator branch June 13, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rojkov rojkov rojkov approved these changes

@mythi mythi mythi approved these changes

@uniemimu uniemimu Awaiting requested review from uniemimu

@kad kad Awaiting requested review from kad

@ozhuraki ozhuraki Awaiting requested review from ozhuraki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSA Operator
3 participants
@bart0sh @rojkov @mythi