-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-wide: drop deprecated io/ioutil #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This seems a bit pre-mature as this change is supported only from Go v1.16 onward. (CI seems to be still at v1.15, Debian testing is still at v1.15, Ubuntu supports v1.16 only from 21.04 onwards (released last month), and e.g. Fedora 33 is also still at Go v1.15.) |
We have plans to move to v1.16 but need the base image conversion done first (so that we can pull |
c1509f4
to
57372bf
Compare
Codecov Report
@@ Coverage Diff @@
## main #630 +/- ##
==========================================
- Coverage 57.75% 57.61% -0.14%
==========================================
Files 31 31
Lines 2192 2192
==========================================
- Hits 1266 1263 -3
- Misses 853 855 +2
- Partials 73 74 +1
Continue to review full report at Codecov.
|
Also, update the documentation to reflect what is needed to enable and use '-mode kernel'. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Go 1.16 release notes announced the deprecation of io/ioutil [1]. It's easy for us to move to use what is was recommended so just do it. [1] https://golang.org/doc/go1.16#ioutil Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kad could you please merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Go 1.16 release notes announced the deprecation of io/ioutil [1]. It's easy
for us to move to use what is was recommended so just do it.
[1] https://golang.org/doc/go1.16#ioutil
Closes: #612
Signed-off-by: Mikko Ylinen mikko.ylinen@intel.com