Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: drop deprecated io/ioutil #630

Merged
merged 3 commits into from
Jun 4, 2021
Merged

tree-wide: drop deprecated io/ioutil #630

merged 3 commits into from
Jun 4, 2021

Conversation

mythi
Copy link
Contributor

@mythi mythi commented May 4, 2021

Go 1.16 release notes announced the deprecation of io/ioutil [1]. It's easy
for us to move to use what is was recommended so just do it.

[1] https://golang.org/doc/go1.16#ioutil

Closes: #612

Signed-off-by: Mikko Ylinen mikko.ylinen@intel.com

bart0sh
bart0sh previously approved these changes May 4, 2021
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eero-t
Copy link
Contributor

eero-t commented May 5, 2021

This seems a bit pre-mature as this change is supported only from Go v1.16 onward.

(CI seems to be still at v1.15, Debian testing is still at v1.15, Ubuntu supports v1.16 only from 21.04 onwards (released last month), and e.g. Fedora 33 is also still at Go v1.15.)

@mythi
Copy link
Contributor Author

mythi commented May 5, 2021

This seems a bit pre-mature as this change is supported only from Go v1.16 onward.

We have plans to move to v1.16 but need the base image conversion done first (so that we can pull golang:1.16-buster). I'll finish this and bump up the CI versions afterwards.

@mythi mythi force-pushed the PR-2021-029 branch 2 times, most recently from c1509f4 to 57372bf Compare May 28, 2021 11:30
@mythi mythi marked this pull request as ready for review May 28, 2021 11:31
@codecov-commenter
Copy link

Codecov Report

Merging #630 (771eac3) into main (a207bfe) will decrease coverage by 0.13%.
The diff coverage is 84.00%.

❗ Current head 771eac3 differs from pull request most recent head 57372bf. Consider uploading reports for the commit 57372bf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   57.75%   57.61%   -0.14%     
==========================================
  Files          31       31              
  Lines        2192     2192              
==========================================
- Hits         1266     1263       -3     
- Misses        853      855       +2     
- Partials       73       74       +1     
Impacted Files Coverage Δ
pkg/fpga/bitstream/aocx.go 8.79% <0.00%> (ø)
pkg/fpga/fpga_linux.go 0.00% <0.00%> (ø)
pkg/fpga/utils.go 0.00% <0.00%> (ø)
cmd/qat_plugin/kerneldrv/kerneldrv.go 73.79% <50.00%> (ø)
cmd/fpga_plugin/fpga_plugin.go 69.86% <100.00%> (ø)
cmd/gpu_nfdhook/labeler.go 70.21% <100.00%> (ø)
cmd/gpu_plugin/gpu_plugin.go 85.00% <100.00%> (ø)
cmd/qat_plugin/dpdkdrv/dpdkdrv.go 86.36% <100.00%> (ø)
cmd/vpu_plugin/vpu_plugin.go 70.63% <100.00%> (ø)
pkg/idxd/plugin.go 56.96% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a207bfe...57372bf. Read the comment docs.

mythi added 3 commits June 2, 2021 13:39
Also, update the documentation to reflect what is needed to
enable and use '-mode kernel'.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Go 1.16 release notes announced the deprecation of io/ioutil [1]. It's easy
for us to move to use what is was recommended so just do it.

[1] https://golang.org/doc/go1.16#ioutil

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi
Copy link
Contributor Author

mythi commented Jun 2, 2021

@bart0sh @rojkov ready for review/merge

Copy link
Contributor

@uniemimu uniemimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rojkov
Copy link
Contributor

rojkov commented Jun 4, 2021

@kad could you please merge?

Copy link
Member

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kad kad merged commit 37daf67 into intel:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move to k8s.io 1.21 API and Go 1.16
7 participants