go.mod: move to Go 1.17 #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythi
commented
Oct 8, 2021
.github/workflows/ci.yaml
Outdated
| @@ -41,7 +41,7 @@ jobs: | |||
| run: | | |||
| echo "$(go env GOPATH)/bin" >> $GITHUB_PATH | |||
| echo "MOD_PATH=$(go env GOPATH)/pkg/mod" >> $GITHUB_ENV | |||
| - uses: actions/cache@v1 | |||
| - uses: actions/cache@v2 | |||
| with: | |||
| path: ${{ env.MOD_PATH }} | |||
There was a problem hiding this comment.
FWIW, the official doc uses:
path: |
~/.cache/go-build
~/go/pkg/mod
maybe we don't need MOD_PATH either?
There was a problem hiding this comment.
Yep, worth checking. I don't remember where this MOD_PATH came from. Probably that was in the docs for cache@v1.
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
go mod tidy adds more requirements because of the changes in 1.17: "Go versions 1.17 and higher retain more requirements in order to support lazy module loading." Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 60.06% 60.06%
=======================================
Files 32 32
Lines 2782 2782
=======================================
Hits 1671 1671
Misses 1028 1028
Partials 83 83 Continue to review full report at Codecov.
|
bart0sh
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go mod tidy adds more requirements because of the changes in 1.17:
"Go versions 1.17 and higher retain more requirements in order to
support lazy module loading."
Closes: #716
Signed-off-by: Mikko Ylinen mikko.ylinen@intel.com