-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add DLB support #753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hj-johannes-lee
requested review from
bart0sh,
mythi and
rojkov
as code owners
November 16, 2021 13:47
mythi
reviewed
Nov 16, 2021
hj-johannes-lee
force-pushed
the
dlb-operator
branch
from
November 17, 2021 09:37
a0fe698
to
0fb7cfd
Compare
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
hj-johannes-lee
force-pushed
the
dlb-operator
branch
from
November 17, 2021 09:52
0fb7cfd
to
ff90348
Compare
bart0sh
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
rojkov
approved these changes
Nov 18, 2021
hj-johannes-lee
referenced
this pull request
in hj-johannes-lee/intel-device-plugins-for-kubernetes
Jan 3, 2022
#753 had a huge mistake that changed operator manifest yaml file. Some part was unintentionally copied and pasted, and no one noticed. Therefore, this commit replaces the yaml file with the command "operator-sdk generate".
hj-johannes-lee
referenced
this pull request
in hj-johannes-lee/intel-device-plugins-for-kubernetes
Jan 3, 2022
\#753 had a huge mistake that changed operator manifest yaml file. Some part was unintentionally copied and pasted, and no one noticed. Therefore, this commit replaces the yaml file with the command "operator-sdk generate".
hj-johannes-lee
referenced
this pull request
in hj-johannes-lee/intel-device-plugins-for-kubernetes
Jan 3, 2022
\#753 had a huge mistake that changed operator manifest yaml file. Some part was unintentionally copied and pasted, and no one noticed. Therefore, this commit replaces the yaml file with the command "operator-sdk generate". Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
hj-johannes-lee
referenced
this pull request
in hj-johannes-lee/intel-device-plugins-for-kubernetes
Jan 3, 2022
PR #753 had a huge mistake that changed operator manifest yaml file. Some part was unintentionally copied and pasted, and no one noticed. Therefore, this commit replaces the yaml file with the command "operator-sdk generate". Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
hj-johannes-lee
referenced
this pull request
in hj-johannes-lee/intel-device-plugins-for-kubernetes
Jan 4, 2022
PR #753 had a huge mistake that changed operator manifest yaml file. Some part was unintentionally copied and pasted, and no one noticed. Therefore, this commit replaces the yaml file with the command "operator-sdk generate". Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change for plugin daemonset yaml file too since terminationMessagePath field is necessary to make the operator work without any permission problem.
Signed-off-by: Hyeongju Johannes Lee hyeongju.lee@intel.com