Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envtest: add DlbDevicePlugin tests #760

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

hj-johannes-lee
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee commented Nov 22, 2021

envtest:

  • add DlbDevicePlugin tests

@mythi
Copy link
Contributor

mythi commented Nov 22, 2021

out that there was an update of tutorial that we followed for suite_test.go file

Let's have these changes in a commit of it's own and update ci.yaml and Jenkinsfile part of it. Everything DLB related should go into its own commit.

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hj-johannes-lee nice, thanks!

Let's just re-organize the changes.

@hj-johannes-lee
Copy link
Contributor Author

@mythi Umm,, do you mean to change the previous commit (that is merged earlier) to include the changes of this pr?

@mythi
Copy link
Contributor

mythi commented Nov 22, 2021

@hj-johannes-lee that's not possible. I meant that just split the changes in this PR into the two commits differently.

@codecov-commenter
Copy link

Codecov Report

Merging #760 (1ed1f51) into main (db20ce1) will decrease coverage by 6.64%.
The diff coverage is 52.43%.

❗ Current head 1ed1f51 differs from pull request most recent head 81a6212. Consider uploading reports for the commit 81a6212 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   61.24%   54.59%   -6.65%     
==========================================
  Files          33       39       +6     
  Lines        2895     3515     +620     
==========================================
+ Hits         1773     1919     +146     
- Misses       1039     1489     +450     
- Partials       83      107      +24     
Impacted Files Coverage Δ
pkg/controllers/sgx/controller.go 16.51% <17.07%> (ø)
pkg/controllers/dsa/controller.go 13.93% <77.77%> (ø)
pkg/controllers/gpu/controller.go 36.64% <78.57%> (ø)
pkg/controllers/dlb/controller.go 19.64% <100.00%> (ø)
pkg/controllers/fpga/controller.go 19.04% <100.00%> (ø)
pkg/controllers/qat/controller.go 22.78% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db20ce1...81a6212. Read the comment docs.

@hj-johannes-lee hj-johannes-lee changed the title operator: add DLB envtest & ci: use 1.22.1 version of k8s instead of 1.20.2 envtest: add DLB envtest & ci: use 1.22.1 version of k8s instead of 1.20.2 Nov 23, 2021
@hj-johannes-lee hj-johannes-lee changed the title envtest: add DLB envtest & ci: use 1.22.1 version of k8s instead of 1.20.2 envtest: add DlbDevicePlugin tests & ci: use 1.22.1 version of k8s instead of 1.20.2 Nov 23, 2021
mythi
mythi previously approved these changes Nov 23, 2021
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
@hj-johannes-lee hj-johannes-lee changed the title envtest: add DlbDevicePlugin tests & ci: use 1.22.1 version of k8s instead of 1.20.2 envtest: add DlbDevicePlugin tests Nov 25, 2021
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bart0sh bart0sh merged commit b1c5285 into intel:main Nov 29, 2021
@hj-johannes-lee hj-johannes-lee deleted the envtest branch November 29, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants