-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
envtest: add DlbDevicePlugin tests #760
Conversation
Let's have these changes in a commit of it's own and update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hj-johannes-lee nice, thanks!
Let's just re-organize the changes.
@mythi Umm,, do you mean to change the previous commit (that is merged earlier) to include the changes of this pr? |
@hj-johannes-lee that's not possible. I meant that just split the changes in this PR into the two commits differently. |
f6df051
to
81a6212
Compare
Codecov Report
@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 61.24% 54.59% -6.65%
==========================================
Files 33 39 +6
Lines 2895 3515 +620
==========================================
+ Hits 1773 1919 +146
- Misses 1039 1489 +450
- Partials 83 107 +24
Continue to review full report at Codecov.
|
81a6212
to
4115f9b
Compare
4115f9b
to
b5cc9ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
b5cc9ad
to
e0356fa
Compare
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
e0356fa
to
66fd91a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
envtest: