Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: dsa: Handle initcontainer and ConfigMap updates #761

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

ozhuraki
Copy link
Contributor

Closes #729

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozhuraki LGTM, thanks! Please check the linter errors and let's rebase after the go:embed PR.

@ozhuraki
Copy link
Contributor Author

ozhuraki commented Dec 1, 2021

@bartosh @mythi
Thanks! Rebased, sorry for a delay.

@ozhuraki
Copy link
Contributor Author

ozhuraki commented Dec 1, 2021

@mythi

intel-idxd-config-initcontainer?

Fixed, thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #761 (4597371) into main (2f5275c) will decrease coverage by 0.55%.
The diff coverage is 1.28%.

❗ Current head 4597371 differs from pull request most recent head fa6ae7a. Consider uploading reports for the commit fa6ae7a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   54.59%   54.04%   -0.56%     
==========================================
  Files          39       39              
  Lines        3515     3551      +36     
==========================================
  Hits         1919     1919              
- Misses       1489     1525      +36     
  Partials      107      107              
Impacted Files Coverage Δ
pkg/controllers/dsa/controller.go 10.75% <1.28%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5275c...fa6ae7a. Read the comment docs.

mythi
mythi previously approved these changes Dec 1, 2021
@mythi
Copy link
Contributor

mythi commented Dec 1, 2021

I missed the linter check so "conditional approval". :-)

@ozhuraki
Copy link
Contributor Author

ozhuraki commented Dec 1, 2021

@mythi
Thanks! Changes:

  • Fixed linter checks

Closes #729

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mythi mythi merged commit b4192b0 into intel:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InitImage cannot be updated to DsaDevicePlugin
4 participants