-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: dsa: Handle initcontainer and ConfigMap updates #761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ozhuraki LGTM, thanks! Please check the linter errors and let's rebase after the go:embed
PR.
ceb297e
to
7da6ff3
Compare
7da6ff3
to
fa6ae7a
Compare
Fixed, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 54.59% 54.04% -0.56%
==========================================
Files 39 39
Lines 3515 3551 +36
==========================================
Hits 1919 1919
- Misses 1489 1525 +36
Partials 107 107
Continue to review full report at Codecov.
|
fa6ae7a
to
55526fb
Compare
I missed the linter check so "conditional approval". :-) |
55526fb
to
5f0166f
Compare
@mythi
|
Closes #729 Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
5f0166f
to
f92394f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Closes #729