Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add dlb test #770

Merged
merged 1 commit into from
Dec 2, 2021
Merged

e2e: add dlb test #770

merged 1 commit into from
Dec 2, 2021

Conversation

hj-johannes-lee
Copy link
Contributor

I made e2e test for dlb. It needs both pf and vf in the node where the e2e test runs.
@mythi Sorry, I don't remember where you said to put the information about this matter. Please tell me again.

In addition, I put resource requests and limits for both of resources. Would it be better to divide same as the yaml file of the demo file?

Signed-off-by: Hyeongju Johannes Lee hyeongju.lee@intel.com

@mythi
Copy link
Contributor

mythi commented Nov 30, 2021

@hj-johannes-lee I did not have any concrete proposal but we could have a section in the README to guide users to setup the VFs.

test/e2e/dlb/dlb.go Outdated Show resolved Hide resolved
test/e2e/dlb/dlb.go Outdated Show resolved Hide resolved
test/e2e/dlb/dlb.go Outdated Show resolved Hide resolved
@hj-johannes-lee
Copy link
Contributor Author

@mythi @bart0sh Sorry, idk whether you noticed or not, but at some point my laptop stopped working, and it happened after the meeting ended... I lost all of my notes.. so I did as far as I remember.! If I forgot something, plz let me know.!

@hj-johannes-lee hj-johannes-lee marked this pull request as ready for review December 1, 2021 13:31
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's a good start but let's continue to add more tests later.

@bart0sh bart0sh merged commit 2319387 into intel:main Dec 2, 2021
@hj-johannes-lee hj-johannes-lee deleted the e2e-dlb branch December 2, 2021 11:38
@hj-johannes-lee hj-johannes-lee mentioned this pull request Dec 3, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants