Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to k8s.io v1.23.0 and controller-runtime v0.11.0-beta.0 #788

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Dec 7, 2021

Signed-off-by: Mikko Ylinen mikko.ylinen@intel.com

@mythi mythi force-pushed the PR-2021-068 branch 2 times, most recently from 9d2b951 to a3af18e Compare December 7, 2021 16:25
@mythi mythi changed the title move to k8s.io v1.23.0-rc.1 and controller-runtime v0.11.0-beta.0 move to k8s.io v1.23.0 and controller-runtime v0.11.0-beta.0 Dec 8, 2021
@mythi mythi force-pushed the PR-2021-068 branch 3 times, most recently from bee53c8 to 481a778 Compare December 9, 2021 06:05
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi mythi marked this pull request as ready for review December 9, 2021 08:25
@mythi mythi requested review from kad and rojkov as code owners December 9, 2021 08:25
@codecov-commenter
Copy link

Codecov Report

Merging #788 (25abf1d) into main (26f1a0e) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
+ Coverage   53.70%   53.79%   +0.08%     
==========================================
  Files          39       39              
  Lines        3545     3545              
==========================================
+ Hits         1904     1907       +3     
+ Misses       1531     1529       -2     
+ Partials      110      109       -1     
Impacted Files Coverage Δ
pkg/fpgacontroller/patcher/patchermanager.go 100.00% <ø> (ø)
pkg/deviceplugin/server.go 85.79% <0.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f1a0e...25abf1d. Read the comment docs.

@mythi
Copy link
Contributor Author

mythi commented Dec 10, 2021

tested with the e2e Admission tests and intel-deviceplugin-operator.

Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rojkov rojkov merged commit d427656 into intel:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants