Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateContext test does not check the min resolution #83

Closed
XinfengZhang opened this issue Dec 29, 2017 · 7 comments · Fixed by #84
Closed

CreateContext test does not check the min resolution #83

XinfengZhang opened this issue Dec 29, 2017 · 7 comments · Fixed by #84

Comments

@XinfengZhang
Copy link
Contributor

in TEST_P(VAAPICreateContext, CreateContext)
only max-resolution is checked.

@uartie
Copy link
Contributor

uartie commented Jan 2, 2018

@XinfengZhang can you specify the specific test cases that fail?

@uartie
Copy link
Contributor

uartie commented Jan 2, 2018

I see several of them fail due to iHD driver not returning any surface attributes for min/max width/height (e.g. VAProfileVC1Advanced:VAEntrypointVLD).

@uartie
Copy link
Contributor

uartie commented Jan 2, 2018

@XinfengZhang In iHD driver source, min/max width/height attributes are only returned for VAEntrypointVideoProc and all those test cases pass. The other tests fail because the driver does not return min/max attributes.

I agree, though, that the test should check min resolution too... but this is not the cause for the failures since driver doesn't even return those attribs. Please fix the driver to provide those attribs.

@uartie
Copy link
Contributor

uartie commented Jan 2, 2018

On the flip-side, I suppose if driver does not specify VASurfaceAttribMaxWidth/Height or VASurfaceAttribMinWidth/Height then applications/tests should assume "any" max is allowed and 0 (or 1) is minimum? @xhaihao what's your recommendation?

@xhaihao
Copy link
Contributor

xhaihao commented Jan 4, 2018

I prefer '1' as the minimum if the driver doesn't set VASurfaceAttribMinWidth/Height. I agree 'any' max should be allowed if the driver doesn't specify VASurfaceAttribMaxWidth/Height.

@XinfengZhang
Copy link
Contributor Author

@uartie, there are several PR in the https://github.com/intel/media-driver/pulls, Max/Min solution is added for both Decode & Encode, after them, there are still failed. I checked the failed case , and find , if driver report min resolution is 32x32, but our test still expect success with resolution 16x16.

@uartie
Copy link
Contributor

uartie commented Jan 4, 2018

@XinfengZhang I will submit a patch to fix that here.

uartie added a commit to uartie/libva-utils that referenced this issue Jan 4, 2018
The minimum surface resolution needs to be considered
when creating a context in CreateContext test.

Fixes intel#83

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
@uartie uartie closed this as completed in #84 Jan 5, 2018
uartie added a commit that referenced this issue Jan 5, 2018
The minimum surface resolution needs to be considered
when creating a context in CreateContext test.

Fixes #83

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants