Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SurfaceAttributes should not be set together #91

Closed
XinfengZhang opened this issue Jan 16, 2018 · 1 comment · Fixed by #97
Closed

SurfaceAttributes should not be set together #91

XinfengZhang opened this issue Jan 16, 2018 · 1 comment · Fixed by #97
Assignees
@uartie

Comments

@XinfengZhang
Copy link
Contributor

when we call vaQuerySurfaceAttributes, for the attributes type == VASurfaceAttribMemoryType, driver may report several support memory type method, but it does not means you can set it directly into driver by vaCreateSurfaces. for example, if you set the value tobe VA_SURFACE_ATTRIB_MEM_TYPE_VA | VA_SURFACE_ATTRIB_MEM_TYPE_USER_PTR |VA_SURFACE_ATTRIB_MEM_TYPE_KERNEL_DRM | VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME = 0x30000005, but if vaCreateSurfaces set the value to be 0x30000005, driver certainly does not know the real memory type. it will block the test cases.
@XinfengZhang XinfengZhang changed the title SurfaceAttributes cant set together SurfaceAttributes should not be set together Jan 16, 2018
@XinfengZhang
Copy link
Contributor Author

what I mentioned is TEST_P(VAAPICreateSurfaces, CreateSurfacesNoConfigAttrib)

@uartie uartie self-assigned this Jan 16, 2018
uartie added a commit to uartie/libva-utils that referenced this issue Jan 17, 2018
@uartie
test/createsurfaces: refactor and fix test bugs
e67c693 
Take into account bitfield attributes when creating
config and surfaces.

Take into account min/max surface resolution when
creating surfaces.

Use new fixture methods for greater control in test
cases.

Fixes intel#91
Fixes intel#92

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
@uartie uartie mentioned this issue Jan 17, 2018
Merged
uartie added a commit to uartie/libva-utils that referenced this issue Jan 17, 2018
@uartie
test/createsurfaces: refactor and fix test bugs
5955bf3 
Take into account bitfield attributes when creating
config and surfaces.

Take into account min/max surface resolution when
creating surfaces.

Use new fixture methods for greater control in test
cases.

Fixes intel#91
Fixes intel#92

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 18, 2018
@uartie
test/createsurfaces: refactor and fix test bugs
bff3873 
Take into account bitfield attributes when creating
config and surfaces.

Take into account min/max surface resolution when
creating surfaces.

Use new fixture methods for greater control in test
cases.

Fixes intel#91
Fixes intel#92

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 19, 2018
@uartie
test/createsurfaces: refactor and fix test bugs
a36bf99 
Take into account bitfield attributes when creating
config and surfaces.

Take into account min/max surface resolution when
creating surfaces.

Use new fixture methods for greater control in test
cases.

Fixes intel#91
Fixes intel#92

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 19, 2018
@uartie
test/createsurfaces: refactor and fix test bugs
e7f4c03 
Take into account bitfield attributes when creating
config and surfaces.

Use new fixture methods for greater control in test
cases.

Fixes intel#91
Fixes intel#92

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/libva-utils that referenced this issue Jan 22, 2018
@uartie
test/createsurfaces: refactor and fix test bugs
5d4a648 
Take into account bitfield attributes when creating
config and surfaces.

Use new fixture methods for greater control in test
cases.

Fixes intel#91
Fixes intel#92

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit that referenced this issue Jan 22, 2018
@uartie
test/createsurfaces: refactor and fix test bugs
db37306 
Take into account bitfield attributes when creating
config and surfaces.

Use new fixture methods for greater control in test
cases.

Fixes #91
Fixes #92

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uartie uartie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major test_va_api refactoring and bug fixes uartie/libva-utils
2 participants
@uartie @XinfengZhang