Skip to content

Commit

Permalink
md/raid10: check slab-out-of-bounds in md_bitmap_get_counter
Browse files Browse the repository at this point in the history
If we write a large number to md/bitmap_set_bits, md_bitmap_checkpage()
will return -EINVAL because 'page >= bitmap->pages', but the return value
was not checked immediately in md_bitmap_get_counter() in order to set
*blocks value and slab-out-of-bounds occurs.

Move check of 'page >= bitmap->pages' to md_bitmap_get_counter() and
return directly if true.

Fixes: ef42567 ("md/bitmap: optimise scanning of empty bitmaps.")
Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230515134808.3936750-2-linan666@huaweicloud.com
  • Loading branch information
Li Nan authored and liu-song-6 committed Jun 13, 2023
1 parent 3de1355 commit 301867b
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions drivers/md/md-bitmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,7 @@ __acquires(bitmap->lock)
{
unsigned char *mappage;

if (page >= bitmap->pages) {
/* This can happen if bitmap_start_sync goes beyond
* End-of-device while looking for a whole page.
* It is harmless.
*/
return -EINVAL;
}

WARN_ON_ONCE(page >= bitmap->pages);
if (bitmap->bp[page].hijacked) /* it's hijacked, don't try to alloc */
return 0;

Expand Down Expand Up @@ -1387,6 +1380,14 @@ __acquires(bitmap->lock)
sector_t csize;
int err;

if (page >= bitmap->pages) {
/*
* This can happen if bitmap_start_sync goes beyond
* End-of-device while looking for a whole page or
* user set a huge number to sysfs bitmap_set_bits.
*/
return NULL;
}
err = md_bitmap_checkpage(bitmap, page, create, 0);

if (bitmap->bp[page].hijacked ||
Expand Down

0 comments on commit 301867b

Please sign in to comment.