Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for kernel sgx patch V29 #530

Merged
merged 1 commit into from May 9, 2020
Merged

Conversation

haitaohuang
Copy link
Contributor

Signed-off-by: Haitao Huang 4699115+haitaohuang@users.noreply.github.com

Copy link

@jhand2 jhand2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with Open Enclave against v29 of the upstream driver and everything looks good. Thanks!

Signed-off-by: Haitao Huang <4699115+haitaohuang@users.noreply.github.com>
@haitaohuang
Copy link
Contributor Author

Based on LKML discussion I changed the initial mmap for enclave address range to MAP_PRIVATE from MAP_SHARED. The later mmap calls did not change.

Tested with SampleCommonLoader and SampleEnclaves, still works for both v29 and v28

@haitaohuang haitaohuang merged commit f896034 into intel:master May 9, 2020
carmenyh pushed a commit to google/asylo that referenced this pull request May 26, 2020
This commit integrates upstream changes made by Intel to the Linux SGX
SDK which includes fixes for the v29 kernel driver that haven't been
included in a linux_sgx release [1]. A slight modification is made to
enclave_create() to maintain compatibility with out-of-kernel drivers.

[1]: intel/linux-sgx#530

PiperOrigin-RevId: 311550828
Change-Id: I5a0342d66a765d1c857075fd8c3c041eccf5c7be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants