distro/adaptation: sort and remove duplicate lines #1

liuhangbin · 2017-04-26T03:43:30Z

CentOS and Fedora have a lot in common. But when add new packets, we may miss some dependence or add duplicated lines due to un-sorted file.

So I sorted all the files and removed duplicate lines.

Thanks
Hangbin

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

rli9 · 2017-04-26T03:58:53Z

Thanks for making this, that is really helpful.

the latest xfstests-dev can not apply this fixed patch ---------------- ==> Starting prepare()... patching file include/builddefs.in patching file install-sh Hunk #1 FAILED at 1. <<<<<<<<<<<< patch failed 1 out of 1 hunk FAILED -- saving rejects to file install-sh.rej patching file ltp/Makefile patching file src/Makefile Hunk #1 succeeded at 85 (offset 11 lines). ---------------- CC: Wu Chenggang <chenggang.wu@intel.com> Signed-off-by: Li Zhijian <zhijianx.li@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

…to 0x4a28000 The issue is as below: obj_tx_add_range_direct/TEST1: SETUP (check/non-pmem/debug/pmemcheck) obj_tx_add_range_direct/TEST1: START: obj_tx_add_range_direct [MATCHING FAILED, COMPLETE FILE (pmemcheck1.log) BELOW] ... pmemcheck1.log.match:1 ==$(*)== pmemcheck$(*) pmemcheck1.log:1 ==67474== pmemcheck-0.2, a simple persistent store checker pmemcheck1.log.match:2 ==$(*)== Copyright$(*) pmemcheck1.log:2 ==67474== Copyright (c) 2014-2016, Intel Corporation pmemcheck1.log.match:3 ==$(*)== Using Valgrind-$(*) pmemcheck1.log:3 ==67474== Using Valgrind-3.12.0 and LibVEX; rerun with -h for copyright info pmemcheck1.log.match:4 ==$(*)== Command: ./obj_tx_add_range_direct$(*) pmemcheck1.log:4 ==67474== Command: ./obj_tx_add_range_direct /tmp/tmp.WoPbIa5vlI//test_obj_tx_add_range_direct1😘⠝⠧⠍⠇ɗNVMLӜ⥺🙋/testfile1 pmemcheck1.log.match:5 ==$(*)== Parent PID: $(*) pmemcheck1.log:5 ==67474== Parent PID: 67379 pmemcheck1.log.match:6 ==$(*)== pmemcheck1.log:6 ==67474== pmemcheck1.log.match:7 ==$(*)== Number of stores not made persistent: 0 pmemcheck1.log:7 ==67474== brk segment overflow in thread #1: can't grow to 0x4a27000 <=== when allocate memory below 128k, system use brk rather than mmap as default, while mmap behave better. The edge can be changed by MALLOC_MMAP_THRESHOLD_. Set it as zero can make the libc malloc use mmap earlier to ensure system allocate enough brk segment. Signed-off-by: Xiang Dai <xiangx.dai@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

To capture below error: kern :warn : [ 57.182374 ] ============================================ kern :warn : [ 57.182582 ] WARNING: possible recursive locking detected kern :warn : [ 57.182788 ] 4.12.0-rc4-wt-ath-05992-g2728455 #1 Not tainted kern :warn : [ 57.183009 ] -------------------------------------------- kern :warn : [ 57.183237 ] repro-8659a50e./13114 is trying to acquire lock: kern :warn : [ 57.183449 ] (sb_writers#5){.+.+.+}, at: [<ffffffff816956c2>] do_iter_write+0x352/0x7d0 kern :warn : [ 57.183781 ] but task is already holding lock: kern :warn : [ 57.184087 ] (sb_writers#5){.+.+.+}, at: [<ffffffff81696f6d>] do_sendfile+0x9bd/0xcc0 kern :warn : [ 57.184407 ] other info that might help us debug this: kern :warn : [ 57.184705 ] Possible unsafe locking scenario: kern :warn : [ 57.184998 ] CPU0 kern :warn : [ 57.185170 ] ---- kern :warn : [ 57.185332 ] lock(sb_writers#5); kern :warn : [ 57.185510 ] lock(sb_writers#5); kern :warn : [ 57.185685 ] *** DEADLOCK *** kern :warn : [ 57.186067 ] May be due to missing lock nesting notation Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

fix the following issues -------- patching file runtest/syscalls Hunk #1 FAILED at 744. 1 out of 1 hunk FAILED -- saving rejects to file runtest/syscalls.rej -------- Signed-off-by: Hailin Gu <hailinx.gu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

To help auto bisect a number of boot errors. For example, [ 956.671551] BUG: unable to handle kernel NULL pointer dereference at 0000000000000020 [ 956.671557] IP: pgtable_trans_huge_withdraw+0x4c/0xc0 ... [ 956.671650] RIP: pgtable_trans_huge_withdraw+0x4c/0xc0 RSP: ffffc90026b07c20 We failed to auto bisect it since the important "RIP:pgtable_trans_huge_withdraw" feature is missed. The remaining ones like "dmesg.BUG:unable_to_handle_kernel" are way too common. wfg@inn /result/stress-ng/1s-memory-performance/lkp-bdw-ep6/debian-x86_64-2016-08-31.cgz/x86_64-rhel-7.2/gcc-6/bb176f67090ca54869fc1262c913aa69d2ede070/0% cat dmesg.json { "dmesg.boot_failures": [ 1 ], "dmesg.BUG:unable_to_handle_kernel": [ 1 ], "dmesg.Oops:#[##]": [ 1 ], "dmesg.Kernel_panic-not_syncing:Fatal_exception": [ 1 ], ... After patch, $ /c/lkp-tests/stats/dmesg dmesg-lkp-bdw-ep6:20171029153441:x86_64-rhel-7.2:gcc-6:4.14.0-rc6:1 boot_failures: 1 # BUG: unable to handle kernel BUG:unable_to_handle_kernel: 1 message:BUG:unable_to_handle_kernel: [ 328.471917] BUG: unable to handle kernel NULL pointer dereference at 0000000000000020 pattern:BUG:unable_to_handle_kernel: BUG: unable to handle kernel # Oops: Oops:#[##]: 1 message:Oops:#[##]: [ 328.471930] Oops: 0000 [#1] SMP pattern:Oops:#[##]: Oops: + # RIP: pgtable_trans_huge_withdraw+0x + RIP:pgtable_trans_huge_withdraw: 1 + message:RIP:pgtable_trans_huge_withdraw: [ 328.471980] RIP: 0010:pgtable_trans_huge_withdraw+0x4c/0xc0 + pattern:RIP:pgtable_trans_huge_withdraw: RIP: pgtable_trans_huge_withdraw+0x # Kernel panic - not syncing: Fatal exception Kernel_panic-not_syncing:Fatal_exception: 1 message:Kernel_panic-not_syncing:Fatal_exception: [ 328.489702] Kernel panic - not syncing: Fatal exception pattern:Kernel_panic-not_syncing:Fatal_exception: Kernel panic - not syncing: Fatal exception timestamp:last: 328.496311 timestamp:BUG:unable_to_handle_kernel: 328.471917 timestamp:Oops:#[##]: 328.471930 timestamp:RIP:pgtable_trans_huge_withdraw: 328.471980 timestamp:Kernel_panic-not_syncing:Fatal_exception: 328.489702 CC: "Kirill A. Shutemov" <kirill@shutemov.name> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

…g vars for next job before this patch, we assume: A) current job(last job) is: queue -q borrow-1m.yaml -t lkp-bdw-ep3c lizhijian@inn:/result/borrow/1m/lkp-bdw-ep3c/debian-x86_64-2016-08-31.cgz/x86_64-rhel-7.2/gcc-7/d8a5b80568a9cb66810e75b182018e9edb68e8ff/1$ grep initrd job.yaml A.1)initrd: "/osimage/debian/debian-x86_64-2016-08-31.cgz" A.2)modules_initrd: "/pkg/linux/x86_64-rhel-7.2/gcc-7/d8a5b80568a9cb66810e75b182018e9edb68e8ff/modules.cgz" A.3)bm_initrd: "/osimage/deps/debian-x86_64-2016-08-31.cgz/run-ipconfig_2016-11-15.cgz,/osimage/deps/debian-x86_64-2016-08-31.cgz/lkp_2018-04-19.cgz,/osimage/deps/debian-x86_64-2016-08-31.cgz/rsync-rootfs_2016-11-15.cgz,/osimage/deps/debian-x86_64-2016-08-31.cgz/hw_2016-11-15.cgz" A.4)lkp_initrd: "/lkp/lizhijian/lkp-x86_64.cgz" B) next job is: queue -q vip ~/src/jobs/borrow-1h.yaml -s "runtime: 10m" -t lkp-bdw-ep3c -k v4.15 -s "rootfs: inn:/export/lizj" -s "run_on_local_disk: 1" -s "user: lizhijian" lizhijian@inn:/result/borrow/10m/lkp-bdw-ep3c/lizj/x86_64-rhel-7.2/gcc-7/d8a5b80568a9cb66810e75b182018e9edb68e8ff/6$ grep initrd job.yaml B.1)initrd: "/osimage/initramfs/initramfs.cgz" B.2)modules_initrd: "/pkg/linux/x86_64-rhel-7.2/gcc-7/d8a5b80568a9cb66810e75b182018e9edb68e8ff/modules.cgz" B.3)lkp_initrd: "/lkp/lizhijian/lkp-x86_64 comparing with A and B, we know B have no bm_initrd var. but bm_initrd is already exported by current job(last job). So at this case, when we switch to next job, bm_initrd is also merged to the runtime initrd eventhough we don't specify it at job.yaml. that will casue uncentain issue for next job like: --------------- [ 25.847640] Write protecting the kernel read-only data: 18432k [ 25.855558] Freeing unused kernel memory: 2012K [ 25.860953] Freeing unused kernel memory: 60K [ 25.865814] rodata_test: all tests were successful [ 25.871232] Failed to execute /init (error -40) [ 25.876336] Starting init: /sbin/init exists but couldn't execute it (error -40) [ 25.884639] Starting init: /bin/sh exists but couldn't execute it (error -40) [ 25.892612] Kernel panic - not syncing: No working init found. Try passing init= option to kernel. See Linux Documentation/admin-guide/init.rst for guidance. [ 25.908434] CPU: 48 PID: 1 Comm: swapper/0 Not tainted 4.15.0 #1 [ 25.915138] Hardware name: Intel Corporation S2600KPR/S2600KPR, BIOS SE5C610.86B.01.01.0019.101220160604 10/12/2016 [ 25.926787] Call Trace: [ 25.929525] dump_stack+0x5c/0x7b [ 25.933227] ? rest_init+0x90/0xd0 [ 25.937025] panic+0xd5/0x242 [ 25.940337] ? rest_init+0xd0/0xd0 [ 25.944134] kernel_init+0xeb/0x100 [ 25.948021] ret_from_fork+0x35/0x40 [ 25.952135] Kernel Offset: disabled [ 25.961868] ACPI MEMORY or I/O RESET_REG. --------------- it finally causes we cannot boot to local rootfs from a non-pxe rootfs Signed-off-by: Li Zhijian <zhijianx.li@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

cpu-hotplug needs more than 1G memory, switch it to suitable tbox. fix the following issue: ------ [ 3.010139] Kernel panic - not syncing: Out of memory and no killable processes... [ 3.010139] [ 3.011128] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.16.0 #1 [ 3.011128] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014 [ 3.011128] Call Trace: [ 3.011128] dump_stack+0x5c/0x7c [ 3.011128] panic+0xd5/0x242 [ 3.011128] ? dump_header+0x193/0x2ac [ 3.011128] out_of_memory+0x3cb/0x4d0 ------ Signed-off-by: Chen Rong <rongx.a.chen@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

…#1]" to align with others from [ 29.493015 ] Bad pagetable: 000f [#1] PTI to [ 29.493015 ] Bad pagetable: # [#1] PTI Signed-off-by: Chen Rong <rong.a.chen@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

fix the following issue ------ Run: "Double-Precision Whetstone": Illegal instruction; aborting ------ the root cause is benchmark unixbench has updated, patch unixbench.patch doesn't work. ------ liuyd@inn:~/byte-unixbench$ patch -p1 < unixbench.patch patching file UnixBench/Makefile Hunk #1 FAILED at 86. 1 out of 1 hunk FAILED -- saving rejects to file UnixBench/Makefile.rej ------ adjust unixbench.pacth and repack, unixbench runs well. ------ liuyd@inn:/result/unixbench/performance-30%-300s-whetstone-double-ucode=0x7000017/lkp-bdw-de1/debian-x86_64-2019-05-14.cgz/x86_64-rhel-7.6/gcc-7/v5.2/22$ cat unixbench.json { "unixbench.score": [ 3310.6 ], "unixbench.workload": [ 8484974.6 ] } ------ Signed-off-by: Liu Yiding <yidingx.liu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

fix the following issue ------ Run: "Double-Precision Whetstone": Illegal instruction; aborting ------ the root cause is benchmark unixbench has updated, patch unixbench.patch doesn't work. ------ liuyd@inn:~/byte-unixbench$ patch -p1 < unixbench.patch patching file UnixBench/Makefile Hunk intel#1 FAILED at 86. 1 out of 1 hunk FAILED -- saving rejects to file UnixBench/Makefile.rej ------ adjust unixbench.pacth and repack, unixbench runs well. ------ liuyd@inn:/result/unixbench/performance-30%-300s-whetstone-double-ucode=0x7000017/lkp-bdw-de1/debian-x86_64-2019-05-14.cgz/x86_64-rhel-7.6/gcc-7/v5.2/22$ cat unixbench.json { "unixbench.score": [ 3310.6 ], "unixbench.workload": [ 8484974.6 ] } ------ Signed-off-by: Liu Yiding <yidingx.liu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

fix the following issue: sed: -e expression #1, char 16: unterminated `s' command Signed-off-by: Ma XinJian <max.xinjian@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

fix the following issue: ``` 16:28:11 ERROR| [stderr] Checking Testing Environment... 16:28:11 ERROR| [stderr] Linux vm-snb-872bde802a4e 5.4.0-rc2-00278-gda0c9ea146cbe #1 SMP Mon Oct 7 07:38:09 CST 2019 x86_64 GNU/Linux 16:28:11 ERROR| [stderr] Virsh command line tool of libvirt: 3.0.0 16:28:11 ERROR| [stderr] sh: 1: libvirtd: not found 16:28:11 ERROR| [stderr] Traceback (most recent call last): ``` Signed-off-by: Zhou Hao <haox.a.zhou@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

fix the following issue: ``` 14:10:16 INFO | Testing item consumption 14:10:16 ERROR| [stderr] Checking Testing Environment... 14:10:16 ERROR| [stderr] Linux vm-snb-ssd-1f9e9baea779 5.4.0-rc2-00278-gda0c9ea146cbe #1 SMP Mon Oct 7 07:38:09 CST 2019 x86_64 GNU/Linux 14:10:16 ERROR| [stderr] Virsh command line tool of libvirt: 3.0.0 14:10:16 ERROR| [stderr] libvirtd (libvirt) 3.0.0 14:10:16 ERROR| [stderr] error: failed to connect to the hypervisor 14:10:16 ERROR| [stderr] error: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No such file or directory 14:10:16 ERROR| [stderr] ``` Signed-off-by: Zhou Hao <haox.a.zhou@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

will-it-scale has been converted to support python3 in its b8639aaf37f4a, patch can't be applied cleanly anymore: ---- ==> Starting patch_source()... patching file runtest.py Hunk intel#1 FAILED at 48. Hunk intel#2 FAILED at 87. 2 out of 2 hunks FAILED -- saving rejects to file runtest.py.rej ---- Adapt the patch to will-it-scale offcial update. Signed-off-by: Cao jin <jinx.cao@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

first issue: line 20 should not be stated -------------------------- 17 # selftests: bpf: test_maps 18 # test_array_map_batch_ops:PASS 19 # test_sk_storage_map:PASS 20 # test_maps: OK, 0 SKIPPED 21 ok 3 selftests: bpf: test_maps -------------------------- second issue: line 83 should consider blank space or not before OK --------------------------- 78 # selftests: bpf: test_btf 79 # BTF raw test[1] (struct test #1): OK 80 # BTF raw test[7] (global data test #4, unsupported linkage): OK 81 # BTF GET_INFO test[2] (== raw_btf_size-3): 38...39...40...OK 82 # BTF prog info raw test[6] (line_info (No subprog. insn_off >= prog->len)): OK 83 # BTF dedup test[9] (dedup: datasec and vars pass-through):OK 84 # PASS:174 SKIP:0 FAIL:0 85 ok 12 selftests: bpf: test_btf --------------------------- Signed-off-by: MaXinjian <max.xinjian@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

fix below issue ------------------------- [ 941.993076] kexec --noefi -l /opt/rootfs/tmp/pkg/linux/x86_64-rhel-8.3/gcc-9/7427965dab1307b00362e4e26ce59c6477acb17d/vmlinuz-5.8.0-rc6-07305-g7427965dab130 --initrd=/opt/rootfs/tmp/i nitrd-concatenated [ 941.993078] [ 945.315980] --append=ip=::::lkp-hsw-d02::dhcp root=/dev/ram0 user=lkp job=/lkp/jobs/scheduled/lkp-hsw-d02/piglit-quick-116-ucode=0x28-CYCLIC_HEAD-20200723-17943-b27rns-0.yaml ARCH=x86 _64 kconfig=x86_64-rhel-8.3 branch=linux-devel/devel-hourly-2020072209 commit=7427965dab1307b00362e4e26ce59c6477acb17d BOOT_IMAGE=/pkg/linux/x86_64-rhel-8.3/gcc-9/7427965dab1307b00362e4e 26ce59c6477acb17d/vmlinuz-5.8.0-rc6-07305-g7427965dab130 max_uptime=3600 RESULT_ROOT=/result/piglit/quick-116-ucode=0x28/lkp-hsw-d02/debian-10.4-x86_64-20200603.cgz/x86_64-rhel-8.3/gcc-9 /7427965dab1307b00362e4e26ce59c6477acb17d/0 LKP_SERVER=inn nokaslr selinux=0 debug apic=debug sysrq_always_enabled rcupdate.rcu_cpu_stall_timeout=100 net.ifnames=0 printk.devkmsg=on pani c=-1 softlockup_panic=1 nmi_watchdog=panic oops=panic load_ramdisk=2 prompt_ramdisk=0 drbd.minor_count=8 systemd.log_level=err ignore_loglevel console=tty0 earlyprintk=tty [ 945.315982] [ 949.645930] kexec invoked oom-killer: gfp_mask=0x100cc2(GFP_HIGHUSER), order=0, oom_score_adj=-1000 [ 949.654934] CPU: 1 PID: 22328 Comm: kexec Not tainted 5.8.0-rc6-07305-g7427965dab130 #1 [ 949.662894] Hardware name: Dell Inc. OptiPlex 9020/03CPWF, BIOS A11 04/01/2015 [ 949.670077] Call Trace: [ 949.672515] dump_stack+0x57/0x70 [ 949.675811] dump_header+0x4a/0x1fe [ 949.679279] oom_kill_process.cold+0xb/0x10 [ 949.683439] out_of_memory.part.0+0x1ca/0x420 [ 949.687771] out_of_memory+0x67/0xd0 [ 949.691326] __alloc_pages_slowpath.constprop.0+0xcc9/0xdb0 [ 949.696869] ? sched_clock+0x5/0x10 [ 949.700337] __alloc_pages_nodemask+0x2e3/0x330 [ 949.704846] kimage_alloc_pages+0x38/0x150 [ 949.708918] kimage_alloc_page+0xf4/0x2e0 [ 949.712906] kimage_load_segment+0xf8/0x560 [ 949.717065] do_kexec_load+0x199/0x260 [ 949.720792] __x64_sys_kexec_load+0x9d/0xe0 [ 949.724955] do_syscall_64+0x4c/0x90 [ 949.728513] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 949.733538] RIP: 0033:0x7ff35643ef59 [ 949.737091] Code: Bad RIP value. Signed-off-by: Xu JingbiaoX <jingbiaox.xu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

there could be numbers of tests in a whole subtest, and the subtest could run several times. judge the results from the starting of a subtest till its end, regardless how many times it runs. any single test fail, in any run, will regard the whole subtest fail. such like - (1) # Running test: kmod_test_0001 - run #0 # kmod_test_0001_driver: OK! - loading kmod test # kmod_test_0001_driver: OK! - Return value: 256 (MODULE_NOT_FOUND), expected MODULE_NOT_FOUND # kmod_test_0001_fs: SKIP! - loading kmod test # kmod_test_0001_fs: OK! - Return value: -22 (-EINVAL), expected -EINVAL # Tue Sep 15 17:57:51 UTC 2020 # Running test: kmod_test_0001 - run #1 # kmod_test_0001_driver: OK! - loading kmod test # kmod_test_0001_driver: OK! - Return value: 256 (MODULE_NOT_FOUND), expected MODULE_NOT_FOUND # kmod_test_0001_fs: FAIL! - loading kmod test # kmod_test_0001_fs: OK! - Return value: -22 (-EINVAL), expected -EINVAL # Tue Sep 15 17:57:51 UTC 2020 # Running test: kmod_test_0001 - run #2 # kmod_test_0001_driver: OK! - loading kmod test # kmod_test_0001_driver: OK! - Return value: 256 (MODULE_NOT_FOUND), expected MODULE_NOT_FOUND # kmod_test_0001_fs: OK! - loading kmod test # kmod_test_0001_fs: SKIP! - Return value: -22 (-EINVAL), expected -EINVAL (2) # Running test: kmod_test_0011 - run #0 # kmod_test_0011: SKIP! - loading kmod test # kmod_test_0011: FAIL! - Return value: -2 (-ENOENT), expected -ENOENT (3) # Running test: kmod_test_0013 - run #0 # kmod_check_visibility: FAIL! # Test completed all above (1)(2)(3) will be set as fail kmod.kmod.sh.kmod_test_0001.fail: 1 kmod.kmod.sh.kmod_test_0011.fail: 1 kmod.kmod.sh.kmod_test_0013.fail: 1 in case no fail, if all OK, or OK+SKIP, will be set as pass such like (4) all OK (in three runs) # Running test: kmod_test_0002 - run #0 # kmod_test_0002_driver: OK! - loading kmod test # kmod_test_0002_driver: OK! - Return value: 256 (MODULE_NOT_FOUND), expected MODULE_NOT_FOUND # kmod_test_0002_fs: OK! - loading kmod test # kmod_test_0002_fs: OK! - Return value: -22 (-EINVAL), expected -EINVAL # Tue Sep 15 17:57:52 UTC 2020 # Running test: kmod_test_0002 - run #1 # kmod_test_0002_driver: OK! - loading kmod test # kmod_test_0002_driver: OK! - Return value: 256 (MODULE_NOT_FOUND), expected MODULE_NOT_FOUND # kmod_test_0002_fs: OK! - loading kmod test # kmod_test_0002_fs: OK! - Return value: -22 (-EINVAL), expected -EINVAL # Tue Sep 15 17:57:52 UTC 2020 # Running test: kmod_test_0002 - run #2 # kmod_test_0002_driver: OK! - loading kmod test # kmod_test_0002_driver: OK! - Return value: 256 (MODULE_NOT_FOUND), expected MODULE_NOT_FOUND # kmod_test_0002_fs: OK! - loading kmod test # kmod_test_0002_fs: OK! - Return value: -22 (-EINVAL), expected -EINVAL (5) OK+SKIP (last is OK) # Running test: kmod_test_0003 - run #0 # kmod_test_0003: SKIP! - loading kmod test # kmod_test_0003: OK! - Return value: 0 (SUCCESS), expected SUCCESS (6) OK+SKIP (last is SKIP) # Running test: kmod_test_0004 - run #0 # kmod_test_0004: OK! - loading kmod test # kmod_test_0004: SKIP! - Return value: 0 (SUCCESS), expected SUCCESS all above will be set as pass kmod.kmod.sh.kmod_test_0002.pass: 1 kmod.kmod.sh.kmod_test_0003.pass: 1 kmod.kmod.sh.kmod_test_0004.pass: 1 if all are SKIP, will be set as skip (7) # Running test: kmod_test_0010 - run #0 # kmod_test_0010: SKIP! - loading kmod test # kmod_test_0010: SKIP! - Return value: -2 (-ENOENT), expected -ENOENT (8) # Running test: kmod_test_0012 - run #0 # kmod_check_visibility: SKIP! both above will be set as skip kmod.kmod.sh.kmod_test_0010.skip: 1 kmod.kmod.sh.kmod_test_0012.skip: 1 Signed-off-by: Oliver Sang <oliver.sang@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

ignore the following kmsg err stats: ---------------- kern :err : [ 13.708876 ] irq 16: nobody cared (try booting with the "irqpoll" option) kern :warn : [ 13.708881 ] CPU: 7 PID: 0 Comm: swapper/7 Not tainted 5.9.0-rc1-00001-gd3f99f9183068e #1 kern :warn : [ 13.708881 ] Hardware name: /DZ77BH-55K, BIOS BHZ7710H.86A.0097.2012.1228.1346 12/28/2012 kern :warn : [ 13.708882 ] Call Trace: kern :warn : [ 13.708886 ] <IRQ> kern :warn : [ 13.708892 ] dump_stack+0x57/0x80 kern :warn : [ 13.708897 ] __report_bad_irq+0x35/0xa7 kern :warn : [ 13.708899 ] note_interrupt.cold+0xb/0x73 kern :warn : [ 13.708901 ] handle_irq_event_percpu+0x6f/0x80 kern :warn : [ 13.708902 ] handle_irq_event+0x3d/0x5a kern :warn : [ 13.708904 ] handle_fasteoi_irq+0x8b/0x140 kern :warn : [ 13.708907 ] asm_call_on_stack+0x12/0x20 kern :warn : [ 13.708908 ] </IRQ> kern :warn : [ 13.708911 ] common_interrupt+0xb5/0x140 kern :warn : [ 13.708913 ] asm_common_interrupt+0x1e/0x40 kern :warn : [ 13.708916 ] RIP: 0010:cpuidle_enter_state+0xc1/0x3e0 kern :warn : [ 13.708918 ] Code: c4 0f 1f 44 00 00 31 ff e8 5c 1d 78 ff 80 7c 24 0f 00 74 12 9c 58 f6 c4 02 0f 85 fb 02 00 00 31 ff e8 63 f9 7e ff fb 45 85 ed <0f> 88 57 02 00 00 49 63 d5 4c 2b 64 24 10 48 8d 04 52 48 8d 04 82 kern :warn : [ 13.708919 ] RSP: 0018:ffffc900000b7e70 EFLAGS: 00000202 kern :warn : [ 13.708920 ] RAX: ffff88841f3eb340 RBX: ffff88841f3f6100 RCX: 000000000000001f kern :warn : [ 13.708921 ] RDX: 0000000000000000 RSI: 0000000024a78c80 RDI: 0000000000000000 kern :warn : [ 13.708922 ] RBP: ffffffff827643c0 R08: 00000003311cc3eb R09: 000000007fffffff kern :warn : [ 13.708923 ] R10: 0000000000000001 R11: ffff88841f3ea364 R12: 00000003311cc3eb kern :warn : [ 13.708924 ] R13: 0000000000000004 R14: 0000000000000004 R15: ffff888107420000 kern :warn : [ 13.708928 ] cpuidle_enter+0x29/0x40 kern :warn : [ 13.708931 ] do_idle+0x1d9/0x280 kern :warn : [ 13.708933 ] cpu_startup_entry+0x19/0x20 kern :warn : [ 13.708937 ] start_secondary+0x114/0x160 kern :warn : [ 13.708939 ] secondary_startup_64+0xb6/0xc0 kern :err : [ 13.708941 ] handlers: kern :err : [ 13.708945 ] [<0000000013155f90>] usb_hcd_irq kern :emerg : [ 13.708946 ] Disabling IRQ #16 ---------------- Signed-off-by: Chen Rong <rong.a.chen@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

$ rake spec spec=stats PWD = /lkp/rongc/.src-20201203-080610 ENV['LKP_CORE_SRC'] = /lkp/rongc/.src-20201203-080610 ENV['LKP_SRC'] = /lkp/rongc/.src-20201203-080610 ENV['KERNEL_TESTS_SRC'] = /c/kernel-tests /usr/bin/ruby2.3 -I/var/lib/gems/2.3.0/gems/rspec-core-3.9.3/lib:/var/lib/gems/2.3.0/gems/rspec-support-3.9.3/lib /var/lib/gems/2.3.0/gems/rspec-core-3.9.3/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/stats_spec.rb ....................................................................... Finished in 18.8 seconds (files took 0.37557 seconds to load) 71 examples, 0 failures Signed-off-by: Chen Rong <rong.a.chen@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

Some test_progs log line begin with # maxj@inn:/result/kernel-selftests/bpf-ucode=0x5003006/lkp-csl-2sp9/debian-10.4-x86_64-20200603.cgz/x86_64-rhel-8.3-kselftests/gcc-9/v5.14/1$ grep -A6 "# selftests: bpf: test_progs$" kernel-selftests # selftests: bpf: test_progs # #1/1 mov:OK # #1/2 shift:OK # #1/3 addsub:OK # #1/4 mul:OK # #1/5 unknown shift:OK # #1/6 unknown mul:OK However some other test_progs log line begin with space maxj@inn:/result/kernel-selftests/bpf-ucode=0xde/lkp-kbl-nuc1/debian-10.4-x86_64-20200603.cgz/x86_64-rhel-8.3-kselftests/gcc-9/398cfb0c19957442e7bd1eafffc6c9d5027925c5/0$ grep -A6 "# selftests: bpf: test_progs$" kernel-selftests # selftests: bpf: test_progs # Subtest: selftests: bpf: test_progs #1/1 align/mov:OK #1/2 align/shift:OK #1/3 align/addsub:OK #1/4 align/mul:OK #1/5 align/unknown shift:OK Signed-off-by: Ma Xinjian <xinjianx.ma@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

It seems that linkbench print the normal output to stderr INFO 2021-10-19 09:12:11,974 [main]: Config file: config/MyConfig.properties INFO 2021-10-19 09:12:11,974 [main]: Workload config file: /lkp/benchmarks/linkbench/config/FBWorkload.properties INFO 2021-10-19 09:12:11,976 [main]: Starting loaders 10 INFO 2021-10-19 09:12:11,976 [main]: Using random seed -45497324616 since load_random_seed not specified INFO 2021-10-19 09:12:11,999 [main]: Loading real distribution data from /lkp/benchmarks/linkbench/config/Distribution.dat INFO 2021-10-19 09:12:12,223 [main]: Will generate graph nodes during loading INFO 2021-10-19 09:12:12,231 [Thread-10]: Starting loader thread #10 loading nodes INFO 2021-10-19 09:12:13,151 [Thread-1]: Starting loader thread #1 loading links INFO 2021-10-19 09:12:13,202 [Thread-6]: Starting loader thread #6 loading links INFO 2021-10-19 09:12:13,390 [Thread-3]: Starting loader thread #3 loading links INFO 2021-10-19 09:12:13,428 [Thread-9]: Starting loader thread #9 loading links INFO 2021-10-19 09:12:13,515 [Thread-1]: 16000/10000000 id1s loaded (0.2% complete) at 12461.06 id1s/sec avg. 59536 links loaded at 46367.60 links/sec avg. INFO 2021-10-19 09:12:13,534 [Thread-5]: Starting loader thread #5 loading links INFO 2021-10-19 09:12:13,538 [Thread-7]: Starting loader thread #7 loading links INFO 2021-10-19 09:12:13,548 [Thread-2]: Starting loader thread #2 loading links INFO 2021-10-19 09:12:13,597 [Thread-0]: Starting loader thread #0 loading links INFO 2021-10-19 09:12:13,600 [Thread-8]: Starting loader thread #8 loading links INFO 2021-10-19 09:12:13,634 [Thread-3]: 26240/10000000 id1s loaded (0.3% complete) at 18676.16 id1s/sec avg. 100338 links loaded at 71414.95 links/sec avg. INFO 2021-10-19 09:12:13,772 [Thread-6]: 42624/10000000 id1s loaded (0.4% complete) at 27624.11 id1s/sec avg. 154320 links loaded at 100012.96 links/sec avg. INFO 2021-10-19 09:12:13,840 [Thread-4]: Starting loader thread #4 loading links INFO 2021-10-19 09:12:13,999 [Thread-3]: 56960/10000000 id1s loaded (0.6% complete) at 32180.79 id1s/sec avg. 206980 links loaded at 116937.85 links/sec avg. Signed-off-by: Li Zhijian <zhijianx.li@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

xfstests completed but no json because all test expunged. Record expunged test as expunged to fix it. Error: /result/xfstests/4HDD-btrfs-smbv3-generic-387-ucode=0xde/lkp-kbl-d02/debian-10.4-x86_64-20200603.cgz/x86_64-rhel-8.3-func/gcc-9/136057256686de39cc3a07c2e39ef6bc43003ff6/0 cat output 2021-11-23 17:48:16 ./check -E tests/cifs/exclude.incompatible-smb3.txt -E tests/cifs/exclude.very-slow.txt generic/387 FSTYP -- cifs PLATFORM -- Linux/x86_64 lkp-kbl-d02 5.16.0-rc2 #1 SMP Mon Nov 22 17:38:09 CST 2021 generic/387 [expunged] Passed all 0 tests cat last_state is_incomplete_run: 1 Reason: expunged because it is in exclude list. Reviewed-by: Ma Xinjian <xinjianx.ma@intel.com> Signed-off-by: Jie2x Zhou <jie2x.zhou@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

1. The result root dir already copied in local, just move to result root path: ---------------- $ lkp merge 5.13.0-22-generic/ Result root #1: /lkp/result/ebizzy/10s-100x-200%/xxx/debian/defconfig/gcc-8/5.13.0-22-generic $ lkp rt ebizzy xxx /lkp/result/ebizzy/10s-100x-200%/xxx/debian/defconfig/gcc-8/5.13.0-22-generic/0/ 2. The result root dir is already in a right place: ---------------- $ lkp merge /lkp/result/ebizzy/10s-100x-200%/yyy/debian/defconfig/gcc-8/5.13.0-22-generic/ Result root #1: /lkp/result/ebizzy/10s-100x-200%/yyy/debian/defconfig/gcc-8/5.13.0-22-generic $ lkp rt ebizzy yyy /lkp/result/ebizzy/10s-100x-200%/yyy/debian/defconfig/gcc-8/5.13.0-22-generic/0/ ---------------- 3. Copy multi result roots from remote directly: ---------------- $ lkp merge -r lkp-qemu /lkp/result/ebizzy rsync -azh --info=progress2 --delete lkp-qemu:/lkp/result/ebizzy/ /tmp/d20220222-1407734-14b0oe0 120.96M 100% 114.10MB/s 0:00:01 (xfr#156, to-chk=0/176) Result root #1: /lkp/result/ebizzy/10s-100x-200%/lkp-qemu-2/debian/defconfig/gcc-8/5.13.0-22-generic Result root #2: /lkp/result/ebizzy/10s-100x-200%/lkp-qemu-3/debian/defconfig/gcc-8/5.13.0-22-generic Result root #3: /lkp/result/ebizzy/10s-100x-200%/lkp-qemu/debian/defconfig/gcc-8/5.13.0-22-generic $ lkp rt ebizzy lkp-qemu /lkp/result/ebizzy/10s-100x-200%/lkp-qemu-2/debian/defconfig/gcc-8/5.13.0-22-generic/0/ /lkp/result/ebizzy/10s-100x-200%/lkp-qemu-3/debian/defconfig/gcc-8/5.13.0-22-generic/0/ /lkp/result/ebizzy/10s-100x-200%/lkp-qemu/debian/defconfig/gcc-8/5.13.0-22-generic/0/ $ lkp ncompare -c tbox_group -s testcase=ebizzy/commit=5.13.0-22-generic/tbox_group=rongch2-desk -o tbox_group=lkp-qemu -a ========================================================================================= commit/compiler/duration/iterations/kconfig/nr_threads/rootfs/testcase: 5.13.0-22-generic/gcc-8/10s/100x/defconfig/200%/debian/ebizzy tbox_group: rongch2-desk lkp-qemu rongch2-desk lkp-qemu ---------------- --------------------------- fail:runs %reproduction fail:runs | | | 711884:1 0% 711884:1 dmesg.timestamp:last ---------------- CC: "Huang, Ying" <ying.huang@intel.com> Link: #23 Signed-off-by: Chen Rong <rong.a.chen@intel.com> Acked-by: "Huang, Ying" <ying.huang@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

… ]------------' Re: [cpuidle] f01f07f0a5: WARNING:at_drivers/cpuidle/cpuidle.c:#cpuidle_enter_state ----------- Please, start the quote at the "------------[ cut here ]------------" marker, that's what it's for. Then you don't miss the actual warning: [ 4.147181 ][ T0 ] ------------[ cut here ]------------ [ 4.147182 ][ T0 ] intel_idle leaked IRQ state ^^^^^^^^^^^^^^^^^^^^^^^^^^^ is the useful bit that went missing. > [ 4.147200 ][ T0 ] WARNING: CPU: 1 PID: 0 at drivers/cpuidle/cpuidle.c:239 cpuidle_enter_state (drivers/cpuidle/cpuidle.c:239 (discriminator 3)) > [ 4.147205 ][ T0 ] Modules linked in: > [ 4.147207 ][ T0 ] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.18.0-11271-gf01f07f0a501 #1 ----------- Link: https://lore.kernel.org/all/YpiKWcbyoNnvUU6W@hirez.programming.kicks-ass.net/ Signed-off-by: Chen Rong <rong.a.chen@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

Ignore the line include 'SMP KASAN PTI', there's no successful bisection for it, and we can bisect 'RIP:' to instead. dmesg.canonical_address#:#[##]: [ 30.290819 ][ T1 ] general protection fault, probably for non-canonical address 0xe015515540155555: 0000 [#1] SMP KASAN PTI [ 30.302724 ][ T1 ] KASAN: maybe wild-memory-access in range [0x00aaaaaa00aaaaa8-0x00aaaaaa00aaaaaf] [ 30.312527 ][ T1 ] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 6.0.0-rc1 #1 [ 30.319769 ][ T1 ] Hardware name: Dell Inc. OptiPlex 7060/0C96W1, BIOS 1.4.2 06/11/2019 [ 30.328538 ][ T1 ] RIP: 0010:rtnl_kfree_skbs+0x29/0x80 dmesg.Oops:#[##]: [ 28.990178 ][ C5 ] Oops: 0002 [#1] SMP KASAN PTI [ 28.990181 ][ C5 ] CPU: 5 PID: 360 Comm: sed Not tainted 6.0.0-rc1 #1 [ 28.990184 ][ C5 ] Hardware name: Dell Inc. OptiPlex 9020/0DNKMN, BIOS A05 12/05/2013 [ 28.990186 ][ C5 ] RIP: 0010:ahci_handle_port_intr+0x0/0x240 [libahci] dmesg.general_protection_fault:#[##]: [ 26.765621 ][ C4 ] general protection fault: 0000 [#1] SMP KASAN PTI [ 26.765625 ][ C4 ] CPU: 4 PID: 232 Comm: systemd-udevd Not tainted 5.4.210 #2 [ 26.765628 ][ C4 ] Hardware name: Dell Inc. OptiPlex 9020/0DNKMN, BIOS A05 12/05/2013 [ 26.773761 ][ T243 ] scsi host5: ahci [ 26.778482 ][ C4 ] RIP: 0010:deactivate_slab+0x123/0x700 dmesg.stack_guard_page:#[##]: [ 27.151267 ][ C5 ] stack guard page: 0000 [#36] SMP KASAN PTI [ 27.151268 ][ C5 ] CPU: 5 PID: 239 Comm: systemd-udevd Not tainted 6.0.0-rc1 #1 [ 27.151270 ][ C5 ] Hardware name: Dell Inc. OptiPlex 9020/0DNKMN, BIOS A05 12/05/2013 [ 27.151282 ][ C5 ] RIP: 0010:sprintf+0x4d/0x100 Signed-off-by: Chen Rong <rong.a.chen@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

…dency detected: [ 327.929816 ][ C1 ] ====================================================== [ 327.929818 ][ C1 ] WARNING: possible circular locking dependency detected [ 327.929864 ][ C1 ] 5.11.0-00017-ged3cd45f8ca8 #1 Tainted: G T [ 327.929865 ][ C1 ] ------------------------------------------------------ [ 327.929866 ][ C1 ] getty/4382 is trying to acquire lock: [ 327.929867 ][ C1 ] 81bdb92c (console_owner){-.-.}-{0:0}, at: console_unlock+0x1d6/0x38d [ 327.929872 ][ C1 ] [ 327.929874 ][ C1 ] but task is already holding lock: [ 327.929875 ][ C1 ] e9518da0 (&rq->lock){-.-.}-{2:2}, at: rq_lock_irqsave+0xf/0x1f Before: WARNING:possible_circular_locking_dependency_detected After: WARNING:possible_circular_locking_dependency_detected_getty_is_trying_to_acquire_lock:#(console_owner){-.-.}-{#:#},at:console_unlock_but_task_is_already_holding_lock:#(&rq->lock){-.-.}-{#:#},at:rq_lock_irqsave/0x Signed-off-by: Chen Rong <rong.a.chen@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

…-07/lkp-hsw-d01: last_state: soft_timeout In lkp-hsw-d01, btrfs/079 caused oom-kill. output: 2022-09-17 07:32:00 ./check btrfs/070 btrfs/071 btrfs/072 btrfs/073 btrfs/074 btrfs/075 btrfs/076 btrfs/077 btrfs/078 btrfs/079 FSTYP -- btrfs PLATFORM -- Linux/x86_64 lkp-hsw-d01 6.0.0-rc5 #1 SMP Mon Sep 12 12:44:00 CST 2022 MKFS_OPTIONS -- /dev/sdb2 MOUNT_OPTIONS -- /dev/sdb2 /fs/scratch btrfs/070 139s btrfs/071 75s btrfs/072 149s btrfs/073 84s btrfs/074 153s btrfs/075 [not run] Require selinux to be enabled btrfs/076 1s btrfs/077 2s btrfs/078 252s btrfs/079 ==> /tmp/stderr <== Killed Signed-off-by: Jie2x Zhou <jie2x.zhou@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

…pe, bad option, bad superblock Error output: 2022-09-13 01:26:32 ./check -E tests/exclude/ext2 generic/487 FSTYP -- ext2 PLATFORM -- Linux/x86_64 lkp-skl-d05 6.0.0-rc5 #1 SMP Mon Sep 12 12:44:00 CST 2022 MKFS_OPTIONS -- -F -J device=/dev/loop0 /dev/sda4 MOUNT_OPTIONS -- -o acl,user_xattr -o journal_path=/dev/loop0 /dev/sda4 /fs/scratch our local mount routine ... mount: /fs/scratch: wrong fs type, bad option, bad superblock on /dev/sda4, missing codepage or helper program, or other error. Reason: ext2 do not support journal_path option. Signed-off-by: Jie2x Zhou <jie2x.zhou@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

…ption, bad superblock Error output: 2022-09-12 12:42:43 ./check -E tests/exclude/ext2 ext4/029 ext4/002 FSTYP -- ext2 PLATFORM -- Linux/x86_64 lkp-skl-d03 6.0.0-rc5 #1 SMP Mon Sep 12 12:44:00 CST 2022 MKFS_OPTIONS -- -F -J device=/dev/loop0 /dev/sda4 MOUNT_OPTIONS -- -o acl,user_xattr -o journal_path=/dev/loop0 /dev/sda4 /fs/scratch our local mount routine ... mount: /fs/scratch: wrong fs type, bad option, bad superblock on /dev/sda4, missing codepage or helper program, or other error. Reason: ext2 do not support journal_path option. Signed-off-by: Jie2x Zhou <jie2x.zhou@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

This reverts commit 7d603ff. The pattern need further adjustment, take below example parent: [ 76.955339][ T3930] raw_sendmsg: trinity-c6 forgot to set AF_INET. Fix it! [ 79.125417][ T4065] process 'trinity-subchil' launched '/sys/devices/virtual/tty/ptyrc/uevent' with NULL argv: empty string added [ 100.380616][ T5152] ------------[ cut here ]------------ [ 100.381142][ T5152] kernel BUG at net/core/skbuff.c:1689! [ 100.381567][ T5152] invalid opcode: 0000 [intel#1] SMP KASAN PTI <-------------- (1) [ 100.381976][ T5152] CPU: 0 PID: 5152 Comm: trinity-c6 Not tainted 5.19.0-rc4-00048-g26aae8ccbc19 intel#1 4513ad3b9b44065dd13463b0de75a8bf07d27dfc [ 100.382801][ T5152] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-5 04/01/2014 [ 100.383453][ T5152] RIP: 0010:pskb_expand_head+0xb4d/0xb4f commit: [ 130.555997][ T3936] raw_sendmsg: trinity-c3 forgot to set AF_INET. Fix it! [ 145.102933][ T4669] ------------[ cut here ]------------ [ 145.103726][ T4669] kernel BUG at net/core/skbuff.c:1689! [ 145.104327][ T4669] invalid opcode: 0000 [intel#1] SMP KASAN <---------------- (2) [ 145.104867][ T4669] CPU: 0 PID: 4669 Comm: trinity-c2 Not tainted 5.19.0-rc4-00049-gf43b9876e857 intel#1 3e7df4049c7f9f202c3119a5693a74a3a4b3ba71 [ 145.106108][ T4669] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-5 04/01/2014 [ 145.107124][ T4669] RIP: 0010:pskb_expand_head+0xb4d/0xb4f The two invalid opcode lines look equal, if ignore the line of parent, the commit itself will be wrongly judged as the commit that introduces invalid opcode issue. Signed-off-by: Philip Li <philip.li@intel.com>

This reverts commit 7d603ff. The pattern need further adjustment, take below example parent: [ 76.955339][ T3930] raw_sendmsg: trinity-c6 forgot to set AF_INET. Fix it! [ 79.125417][ T4065] process 'trinity-subchil' launched '/sys/devices/virtual/tty/ptyrc/uevent' with NULL argv: empty string added [ 100.380616][ T5152] ------------[ cut here ]------------ [ 100.381142][ T5152] kernel BUG at net/core/skbuff.c:1689! [ 100.381567][ T5152] invalid opcode: 0000 [#1] SMP KASAN PTI <-------------- (1) [ 100.381976][ T5152] CPU: 0 PID: 5152 Comm: trinity-c6 Not tainted 5.19.0-rc4-00048-g26aae8ccbc19 #1 4513ad3b9b44065dd13463b0de75a8bf07d27dfc [ 100.382801][ T5152] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-5 04/01/2014 [ 100.383453][ T5152] RIP: 0010:pskb_expand_head+0xb4d/0xb4f commit: [ 130.555997][ T3936] raw_sendmsg: trinity-c3 forgot to set AF_INET. Fix it! [ 145.102933][ T4669] ------------[ cut here ]------------ [ 145.103726][ T4669] kernel BUG at net/core/skbuff.c:1689! [ 145.104327][ T4669] invalid opcode: 0000 [#1] SMP KASAN <---------------- (2) [ 145.104867][ T4669] CPU: 0 PID: 4669 Comm: trinity-c2 Not tainted 5.19.0-rc4-00049-gf43b9876e857 #1 3e7df4049c7f9f202c3119a5693a74a3a4b3ba71 [ 145.106108][ T4669] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-5 04/01/2014 [ 145.107124][ T4669] RIP: 0010:pskb_expand_head+0xb4d/0xb4f The two invalid opcode lines look equal, if ignore the line of parent, the commit itself will be wrongly judged as the commit that introduces invalid opcode issue. Signed-off-by: Philip Li <philip.li@intel.com>

This reverts commit 631129b. WARNING rcu_torture_stats_print is shown in a Tainted kernel. [ 91.720955][ T0] ================================================================== [ 91.722870][ T0] BUG: KASAN: out-of-bounds in cpu_init_exception_handling+0xb71/0xcce [ 91.725314][ T0] Write of size 2 at addr ffff8881009bfea0 by task swapper/1/0 [ 91.727658][ T0] [ 91.728191][ T0] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.16.0-rc2 #1 a24463070ea22534f6c67668cecaa669e0bcb985 [ 91.766536][ T0] Disabling lock debugging due to kernel taint ... [ 120.265469][ T553] ------------[ cut here ]------------ [ 120.267872][ T553] WARNING: CPU: 0 PID: 553 at kernel/rcu/rcutorture.c:1832 rcu_torture_stats_print+0xb80/0xd99 [rcutorture] ... [ 120.275075][ T553] CPU: 0 PID: 553 Comm: rcu_torture_sta Tainted: G B 5.16.0-rc2 #1 a24463070ea22534f6c67668cecaa669e0bcb985 [ 120.276925][ T553] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-5 04/01/2014 [ 120.278470][ T553] RIP: 0010:rcu_torture_stats_print+0xb80/0xd99 [rcutorture] But such WARNING can occur standalone, which means it is not the result of early oops/panic. [ 130.687780][ T578] ------------[ cut here ]------------ [ 130.689263][ T578] WARNING: CPU: 0 PID: 578 at kernel/rcu/rcutorture.c:1832 rcu_torture_stats_print+0xb80/0xd99 [rcutorture] ... [ 130.693473][ T578] CPU: 0 PID: 578 Comm: rcu_torture_sta Not tainted 5.16.0-rc2-00001-gdce1ca0525bf #1 3c0077784af7403eda198a81ec74f23688d9ec99 ... [ 130.696637][ T578] RIP: 0010:rcu_torture_stats_print+0xb80/0xd99 [rcutorture] This means the rcu_torture_stats_print WARNING worth being recorded. So revert the patch before a better way to know which oops is really related to early occurred issue. Signed-off-by: Philip Li <philip.li@intel.com>

2023-02-23 21:19:06 ./check xfs/027 FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 lkp-ivb-d04 6.2.0-rc4-wt-ath-09849-g1cfee8b6d5cd #1 SMP Sat Jan 21 17:26:16 CST 2023 MKFS_OPTIONS -- -f /dev/sda5 MOUNT_OPTIONS -- /dev/sda5 /fs/scratch xfs/027 _check_xfs_filesystem: filesystem on /dev/sda5 has dirty log (see /lkp/benchmarks/xfstests/results//xfs/027.full for details) Ran: xfs/027 Failures: xfs/027 Failed 1 of 1 tests Signed-off-by: Philip Li <philip.li@intel.com>

…t of standalone ones the standalone tests may cause kernel panic on v6.3 in our experiment. move general bpf selftest earlier so we can run it before standalone ones, and can stats whether bpf make is pass or fail. == before fix == 240/1 unpriv_bpf_disabled/unpriv_bpf_disabled_positive:OK 240/2 unpriv_bpf_disabled/unpriv_bpf_disabled_negative:OK 240 unpriv_bpf_disabled:OK BUG: kernel NULL pointer dereference, address: 0000000000000002 PF: supervisor read access in kernel mode PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP PTI CPU: 0 PID: 22511 Comm: new_name Tainted: G OE 6.3.0 #1 Hardware name: Dell Inc. OptiPlex 7050/062KRH, BIOS 1.2.0 12/22/2016 RIP: 0010:___pcpu_freelist_pop_nmi+0x16e/0x1a0 == after fix == /result/kernel-selftests-bpf/bpf/lkp-kbl-d01/debian-12-x86_64-20220629.cgz/x86_64-rhel-8.3-bpf/gcc-12/457391b0380335d5e9a5babdec90ac53928b23b4/2$ xzgrep bpf.make kernel-selftests-bpf.json.gz "kernel-selftests-bpf.bpf.make.pass": [ Signed-off-by: Yujie Liu <yujie.liu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

current each generic group has 10 tests, and the default timeout is 20m we've seen some cases that mkfs costs about 400s, mount costs 200s, while each test costs 100~200s. the total time will surely exceed 20m and cause soft timeout. increase the default timeout to 30m to have a try, but it is expected that some cases would still resulted in timeout. user :notice: [ 75.470704] 2023-06-20 08:58:04 mkfs -t ext2 -q -F /dev/sda3 user :notice: [ 475.767849] 2023-06-20 09:04:49 mkdir -p /fs/sda1 <-- cost 400s to mkfs ... user :notice: [ 478.848565] 2023-06-20 09:04:52 ./check -E tests/exclude/ext2 generic/240 generic/241 generic/242 generic/243 generic/244 generic/245 generic/246 generic/247 generic/248 generic/249 ... user :notice: [ 548.292093] FSTYP -- ext2 user :notice: [ 548.340053] PLATFORM -- Linux/x86_64 lkp-skl-d02 6.4.0-rc6-06147-gbab5772cb141 #1 SMP PREEMPT_DYNAMIC Mon Jun 19 02:20:39 CST 2023 user :notice: [ 548.355898] MKFS_OPTIONS -- -F /dev/sda4 user :notice: [ 548.364144] MOUNT_OPTIONS -- -o acl,user_xattr /dev/sda4 /fs/scratch kern :warn : [ 645.747951] ext2 filesystem being mounted at /fs/scratch supports timestamps until 2038-01-19 (0x7fffffff) kern :info : [ 714.760473] kmemleak: 2 new suspected memory leaks (see /sys/kernel/debug/kmemleak) kern :warn : [ 736.557045] ext2 filesystem being mounted at /fs/sda1 supports timestamps until 2038-01-19 (0x7fffffff) <-- mount started at 548s and ended at 736s ... user :notice: [ 917.465869] generic/240 180s user :notice: [ 1152.401668] generic/241 235s ... Signed-off-by: Yujie Liu <yujie.liu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

according to below Link, "This is precisely what I'm trying to test. I'm trying to create a directory on top of a permanently empty directory and expecting the failure and checking to see that the mnt_error directory was not created." from code change of f2e7a6265e5a: +static int test_sysctl_run_register_mount_point(void) +{ + sysctl_test_headers.test_h_mnt + = register_sysctl_mount_point("debug/test_sysctl/mnt"); + if (!sysctl_test_headers.test_h_mnt) + return -ENOMEM; + + sysctl_test_headers.test_h_mnterror + = register_sysctl("debug/test_sysctl/mnt/mnt_error", + test_table_unregister); + /* + * Don't check the result.: + * If it fails (expected behavior), return 0. + * If successful (missbehavior of register mount point), we want to see + * mnt_error when we run the sysctl test script + */ + + return 0; +} below is expected: [ 13.869482][ T1] sysctl could not get directory: /debug/test_sysctl/mnt/mnt_error -30 [ 13.870358][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.4.0-rc2-00018-gf2e7a6265e5a #1 [ 13.871103][ T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 [ 13.871103][ T1] Call Trace: [ 13.871103][ T1] <TASK> [ 13.871103][ T1] dump_stack_lvl+0x36/0x50 [ 13.871103][ T1] __register_sysctl_table+0x160/0x180 [ 13.871103][ T1] ? test_firmware_init+0xd0/0xd0 [ 13.871103][ T1] test_sysctl_init+0x1ab/0x1f0 [ 13.871103][ T1] do_one_initcall+0x5a/0x220 [ 13.871103][ T1] do_initcalls+0xc6/0x160 [ 13.871103][ T1] kernel_init_freeable+0x253/0x310 [ 13.871103][ T1] ? rest_init+0xd0/0xd0 [ 13.871103][ T1] kernel_init+0x1a/0x1b0 [ 13.871103][ T1] ret_from_fork+0x1f/0x30 [ 13.871103][ T1] </TASK> Link: https://lore.kernel.org/all/20230606092717.uesyzrptbsbzefbq@localhost/ Signed-off-by: Oliver Sang <oliver.sang@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

the name of generic group is like "generic-group-24", there should be a hypen after deleting the group number, otherwise the match is always false. theoretically this should impact all the generic group tests on xfs filesystem, but didn't see large scale failure actually. rerun generic-group-01 for a try, and the test result is the same before and after the fix, but anyway, this should be a valid fix. == before fix == 2023-07-10 14:03:18 export TEST_DIR=/fs/sda1 2023-07-10 14:03:18 export TEST_DEV=/dev/sda1 2023-07-10 14:03:18 export FSTYP=xfs 2023-07-10 14:03:18 export SCRATCH_MNT=/fs/scratch 2023-07-10 14:03:18 mkdir /fs/scratch -p 2023-07-10 14:03:18 export SCRATCH_DEV=/dev/sda4 2023-07-10 14:03:18 export SCRATCH_LOGDEV=/dev/sda2 2023-07-10 14:03:18 sed "s:^:generic/:" //lkp/benchmarks/xfstests/tests/generic-group-01 2023-07-10 14:03:18 ./check generic/010 generic/012 generic/014 generic/015 generic/016 generic/018 generic/019 FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 lkp-skl-d01 6.4.0 #1 SMP PREEMPT_DYNAMIC Mon Jun 26 15:36:48 CST 2023 MKFS_OPTIONS -- -f /dev/sda4 MOUNT_OPTIONS -- /dev/sda4 /fs/scratch generic/010 53s generic/012 57s generic/014 61s generic/015 56s generic/016 57s generic/018 77s generic/019 109s Ran: generic/010 generic/012 generic/014 generic/015 generic/016 generic/018 generic/019 Passed all 7 tests == after fix == 2023-07-11 02:29:39 export TEST_DIR=/fs/sda1 2023-07-11 02:29:39 export TEST_DEV=/dev/sda1 2023-07-11 02:29:39 export FSTYP=xfs 2023-07-11 02:29:39 export SCRATCH_MNT=/fs/scratch 2023-07-11 02:29:39 mkdir /fs/scratch -p 2023-07-11 02:29:39 export SCRATCH_DEV=/dev/sda4 2023-07-11 02:29:39 export SCRATCH_LOGDEV=/dev/sda2 meta-data=/dev/sda1 isize=512 agcount=4, agsize=13107200 blks = sectsz=4096 attr=2, projid32bit=1 = crc=1 finobt=1, sparse=1, rmapbt=0 = reflink=1 bigtime=0 data = bsize=4096 blocks=52428800, imaxpct=25 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0, ftype=1 log =internal log bsize=4096 blocks=25600, version=2 = sectsz=4096 sunit=1 blks, lazy-count=1 realtime =none extsz=4096 blocks=0, rtextents=0 2023-07-11 02:29:40 export MKFS_OPTIONS=-mreflink=1 2023-07-11 02:29:40 sed "s:^:generic/:" //lkp/benchmarks/xfstests/tests/generic-group-01 2023-07-11 02:29:40 ./check generic/010 generic/012 generic/014 generic/015 generic/016 generic/018 generic/019 FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 lkp-skl-d01 6.4.0 #1 SMP PREEMPT_DYNAMIC Mon Jun 26 15:36:48 CST 2023 MKFS_OPTIONS -- -f -mreflink=1 /dev/sda4 MOUNT_OPTIONS -- /dev/sda4 /fs/scratch generic/010 55s generic/012 58s generic/014 62s generic/015 57s generic/016 58s generic/018 79s generic/019 112s Ran: generic/010 generic/012 generic/014 generic/015 generic/016 generic/018 generic/019 Passed all 7 tests Signed-off-by: Yujie Liu <yujie.liu@intel.com> Signed-off-by: Philip Li <philip.li@intel.com>

part of test_ida [ 106.247813][ T1] vvv Ignore "not allocated" warnings [ 106.248283][ T1] ------------[ cut here ]------------ [ 106.248731][ T1] ida_free called for id=0 which is not allocated. [ 106.249655][ T1] WARNING: CPU: 1 PID: 1 at lib/idr.c:525 ida_free+0x19c/0x220 [ 106.249729][ T1] Modules linked in: [ 106.249743][ T1] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc6-rt4-00096-ga6b892eca31b #1 155c2522c022af59120557d839e60f0b7981d138 [ 106.249770][ T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 [ 106.249774][ T1] RIP: 0010:ida_free+0x19c/0x220 Signed-off-by: Philip Li <philip.li@intel.com>

[ 51.826306][ T1] general protection fault, probably for non-canonical address 0xdffffc0000000046: 0000 [#1] PREEMPT SMP KASAN PTI [ 51.827884][ T1] KASAN: null-ptr-deref in range [0x0000000000000230-0x0000000000000237] [ 51.828645][ T1] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.4.0-rc1-00109-gcc3c44c9fda2 #1 [ 51.828645][ T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 Signed-off-by: Philip Li <philip.li@intel.com>

[ 321.255018][ T315] [main] 340387 iterations. [F:264736 S:75469 HI:44794] [ 321.255081][ T315] [ 322.046276][ T361] GUP no longer grows the stack in trinity-c1 (361): 40001000-40280000 (40000000) [ 322.047086][ T361] CPU: 1 PID: 361 Comm: trinity-c1 Tainted: G W N 6.9.0-rc7 #1 [ 322.047762][ T361] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 [ 322.048523][ T361] Call Trace: [ 322.048776][ T361] <TASK> [ 322.049002][ T361] dump_stack_lvl+0x160/0x200 [ 322.049142][ T361] gup_vma_lookup+0x131/0x140 [ 322.049142][ T361] __get_user_pages+0x186/0xc40 [ 322.049142][ T361] __gup_longterm_locked+0x171/0x1180 [ 322.049142][ T361] ? gup_pgd_range+0x2bd/0x340 [ 322.049142][ T361] ? mark_held_locks+0x40/0x80 [ 322.049142][ T361] internal_get_user_pages_fast+0x2d0/0x600 [ 322.049142][ T361] ? __create_object+0x5e/0xc0 [ 322.049142][ T361] get_user_pages_fast+0x7f/0x100 [ 322.049142][ T361] __iov_iter_get_pages_alloc+0xff/0x640 [ 322.049142][ T361] iov_iter_get_pages2+0x4f/0x80 [ 322.049142][ T361] iter_to_pipe+0x12e/0x400 [ 322.049142][ T361] vmsplice_to_pipe+0x1cb/0x240 [ 322.049142][ T361] __do_sys_vmsplice+0x2ff/0x4c0 [ 322.049142][ T361] ? rseq_get_rseq_cs+0x93/0x440 [ 322.049142][ T361] ? lock_acquire+0xc3/0x300 [ 322.049142][ T361] ? do_syscall_64+0x6e/0x180 [ 322.049142][ T361] do_syscall_64+0x6e/0x180 [ 322.049142][ T361] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 322.049142][ T361] RIP: 0033:0x7f574e7d8719 [ 322.049142][ T361] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d b7 06 0d 00 Signed-off-by: Philip Li <philip.li@intel.com>

[ 68.711008][ T1] trace_kprobe: Testing kprobe tracing: [ 68.730487][ T1] ------------[ cut here ]------------ [ 68.732947][ T1] WARNING: CPU: 0 PID: 1 at kernel/trace/trace_kprobe.c:2109 kprobe_trace_self_tests_init+0xd42/0x1440 [ 68.735335][ T1] Modules linked in: [ 68.736196][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc7 #1 [ 68.737668][ T1] RIP: 0010:kprobe_trace_self_tests_init+0xd42/0x1440 [ 68.739210][ T1] Code: e9 d3 85 e8 e0 24 4f fb e8 5b b7 44 fb 8b 45 c4 85 c0 0f 85 77 f8 ff ff 48 c7 c7 40 56 34 84 e8 c4 c0 28 fb e9 15 f3 ff ff 90 <0f> 0b 90 b9 01 00 00 00 31 d2 be 01 00 00 00 48 c7 c7 38 e9 d3 85 [ 68.743138][ T1] RSP: 0000:ffff888100857d40 EFLAGS: 00010286 [ 68.744305][ T1] RAX: dffffc0000000000 RBX: 00000000fffffff0 RCX: 0000000000000000 [ 68.746039][ T1] RDX: 1ffffffff0ba7d31 RSI: 0000000000000001 RDI: ffffffff85d3e988 [ 68.747771][ T1] RBP: ffff888100857d98 R08: 0000000000000001 R09: ffffed102010af8b [ 68.749361][ T1] R10: ffff888100857c5f R11: 0000000000000000 R12: dffffc0000000000 [ 68.751361][ T1] R13: ffff88818c87d400 R14: ffff88818c87d4e0 R15: ffff88818c8cb450 [ 68.752993][ T1] FS: 0000000000000000(0000) GS:ffff8883ae800000(0000) knlGS:0000000000000000 [ 68.754896][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 68.756195][ T1] CR2: ffff88843ffff000 CR3: 0000000004e8e000 CR4: 00000000000406f0 [ 68.757802][ T1] Call Trace: [ 68.758521][ T1] <TASK> [ 68.759082][ T1] ? show_regs+0x68/0x80 [ 68.759929][ T1] ? __warn+0xcc/0x1c0 [ 68.760810][ T1] ? kprobe_trace_self_tests_init+0xd42/0x1440 [ 68.762160][ T1] ? report_bug+0x29f/0x340 [ 68.763275][ T1] ? handle_bug+0x7b/0xc0 [ 68.764142][ T1] ? exc_invalid_op+0x1c/0x80 [ 68.765065][ T1] ? asm_exc_invalid_op+0x1f/0x40 [ 68.766260][ T1] ? kprobe_trace_self_tests_init+0xd42/0x1440 [ 68.767569][ T1] ? init_kprobe_trace+0x441/0x480 [ 68.768625][ T1] ? __pfx_kprobe_trace_self_tests_init+0x40/0x40 [ 68.770038][ T1] do_one_initcall+0xa3/0x3c0 [ 68.771123][ T1] ? __pfx_do_one_initcall+0x40/0x40 [ 68.772274][ T1] ? parameq+0xc0/0x100 [ 68.773143][ T1] ? trace_kmalloc+0x83/0x200 [ 68.774320][ T1] ? __kasan_kmalloc+0x9c/0xc0 [ 68.775337][ T1] ? __kmalloc+0x326/0x500 [ 68.776289][ T1] ? rcu_is_watching+0x76/0xc0 [ 68.777282][ T1] do_initcalls+0x197/0x2c0 [ 68.778335][ T1] kernel_init_freeable+0x23a/0x340 [ 68.779402][ T1] ? __pfx_kernel_init+0x40/0x40 [ 68.780342][ T1] kernel_init+0x23/0x200 [ 68.781208][ T1] ? __pfx_kernel_init+0x40/0x40 [ 68.782390][ T1] ? __pfx_kernel_init+0x40/0x40 [ 68.783500][ T1] ret_from_fork+0x59/0xc0 [ 68.784482][ T1] ? __pfx_kernel_init+0x40/0x40 [ 68.785523][ T1] ret_from_fork_asm+0x1a/0x80 [ 68.786677][ T1] </TASK> [ 68.787329][ T1] irq event stamp: 5143671 [ 68.788308][ T1] hardirqs last enabled at (5143679): [<ffffffff8144975a>] console_unlock+0x1da/0x200 [ 68.792266][ T1] hardirqs last disabled at (5143688): [<ffffffff8144973f>] console_unlock+0x1bf/0x200 [ 68.794263][ T1] softirqs last enabled at (5143626): [<ffffffff8129c74a>] handle_softirqs+0x38a/0x6c0 [ 68.795855][ T1] softirqs last disabled at (5143615): [<ffffffff8129d3d9>] irq_exit_rcu+0x99/0xc0 [ 68.797312][ T1] ---[ end trace 0000000000000000 ]--- Signed-off-by: Philip Li <philip.li@intel.com>

[ 73.917235][ T1] ### dt-test ### pass of_unittest_lifecycle():3294 [ 73.919973][ T1] ------------[ cut here ]------------ [ 73.921006][ T1] refcount_t: underflow; use-after-free. [ 73.922114][ T1] WARNING: CPU: 0 PID: 1 at lib/refcount.c:28 refcount_warn_saturate+0x2e2/0x500 [ 73.924019][ T1] Modules linked in: [ 73.924764][ T1] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W N 6.9.0-rc7 #1 [ 73.926523][ T1] RIP: 0010:refcount_warn_saturate+0x2e2/0x500 [ 73.927691][ T1] Code: 44 92 71 ff b9 01 00 00 00 31 d2 be 01 00 00 00 48 c7 c7 78 bf db 85 e8 2c 92 71 ff 90 48 c7 c7 80 f2 45 84 e8 9f d4 2e ff 90 <0f> 0b 90 90 b9 01 00 00 00 31 d2 be 01 00 00 00 48 c7 c7 48 bf db T1] RSP: 0000:ffff888100857c40 EFLAGS: 00010286 [ 73.932312][ T1] RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000 [ 73.933643][ T1] RDX: 1ffffffff0b9c379 RSI: 0000000000000001 RDI: ffffffff85ce1bc8 [ 73.936793][ T1] RBP: ffff888100857c50 R08: 0000000000000000 R09: fffffbfff09e9ac8 [ 73.938148][ T1] R10: 0000000000000003 R11: 0000000000000001 R12: 0000000000000003 [ 73.939648][ T1] R13: ffff888115c0e548 R14: 0000000000000003 R15: ffffed1022b81ca9 [ 73.940966][ T1] FS: 0000000000000000(0000) GS:ffff8883ae800000(0000) knlGS:0000000000000000 [ 73.942758][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 73.943973][ T1] CR2: ffff88843ffff000 CR3: 0000000004e8e000 CR4: 00000000000406f0 [ 73.945294][ T1] Call Trace: [ 73.949055][ T1] <TASK> [ 73.949582][ T1] ? show_regs+0x68/0x80 [ 73.950493][ T1] ? __warn+0xcc/0x1c0 [ 73.951284][ T1] ? refcount_warn_saturate+0x2e2/0x500 [ 73.952297][ T1] ? report_bug+0x29f/0x340 [ 73.953072][ T1] ? handle_bug+0x7b/0xc0 [ 73.953824][ T1] ? exc_invalid_op+0x1c/0x80 [ 73.957310][ T1] ? asm_exc_invalid_op+0x1f/0x40 [ 73.958399][ T1] ? refcount_warn_saturate+0x2e2/0x500 [ 73.959469][ T1] kobject_put+0x127/0x180 [ 73.960301][ T1] of_node_put+0x1b/0x40 [ 73.961015][ T1] of_unittest_lifecycle+0x19a/0x500 [ 73.961929][ T1] of_unittest+0x401/0x700 [ 73.962823][ T1] ? __pfx_of_unittest+0x40/0x40 [ 73.963668][ T1] ? __pfx_add_device_randomness+0x40/0x40 [ 73.964645][ T1] ? of_unittest_overlay+0x840/0x880 [ 73.965536][ T1] ? rcu_is_watching+0x76/0xc0 [ 73.966512][ T1] ? __pfx_of_unittest+0x40/0x40 [ 73.967405][ T1] do_one_initcall+0xa3/0x3c0 [ 73.968307][ T1] ? __pfx_do_one_initcall+0x40/0x40 [ 73.969255][ T1] ? parameq+0xc0/0x100 [ 73.970003][ T1] ? trace_kmalloc+0x83/0x200 [ 73.971068][ T1] ? __kasan_kmalloc+0x9c/0xc0 [ 73.971940][ T1] ? __kmalloc+0x326/0x500 [ 73.972697][ T1] ? rcu_is_watching+0x76/0xc0 [ 73.973514][ T1] do_initcalls+0x197/0x2c0 [ 73.974441][ T1] kernel_init_freeable+0x23a/0x340 [ 73.975305][ T1] ? __pfx_kernel_init+0x40/0x40 [ 73.976134][ T1] kernel_init+0x23/0x200 [ 73.976865][ T1] ? __pfx_kernel_init+0x40/0x40 [ 73.977765][ T1] ? __pfx_kernel_init+0x40/0x40 [ 73.978968][ T1] ret_from_fork+0x59/0xc0 [ 73.979737][ T1] ? __pfx_kernel_init+0x40/0x40 [ 73.980572][ T1] ret_from_fork_asm+0x1a/0x80 [ 73.981423][ T1] </TASK> [ 73.981952][ T1] irq event stamp: 5844885 [ 73.982913][ T1] hardirqs last enabled at (5845003): [<ffffffff8144975a>] console_unlock+0x1da/0x200 [ 73.984519][ T1] hardirqs last disabled at (5845010): [<ffffffff8144973f>] console_unlock+0x1bf/0x200 [ 73.986141][ T1] softirqs last enabled at (5845000): [<ffffffff8129c74a>] handle_softirqs+0x38a/0x6c0 [ 73.988152][ T1] softirqs last disabled at (5845027): [<ffffffff8129d3d9>] irq_exit_rcu+0x99/0xc0 [ 73.989697][ T1] ---[ end trace 0000000000000000 ]--- [ 73.990757][ T1] ### dt-test ### EXPECT / : ---[ end trace <<int>> ]--- [ 73.990765][ T1] ### dt-test ### EXPECT / : refcount_t: underflow; use-after-free. [ 73.991927][ T1] ### dt-test ### EXPECT / : WARNING: <<all>> [ 73.993265][ T1] ### dt-test ### EXPECT / : ------------[ cut here ]------------ [ 73.994511][ T1] ### dt-test ### EXPECT_NOT \ : ------------[ cut here ]------------ [ 73.995846][ T1] ### dt-test ### EXPECT_NOT \ : WARNING: <<all>> [ 73.997580][ T1] ### dt-test ### EXPECT_NOT \ : refcount_t: underflow; use-after-free. [ 73.998712][ T1] ### dt-test ### EXPECT_NOT \ : ---[ end trace <<int>> ]--- [ 74.000132][ T1] ### dt-test ### pass of_unittest_lifecycle():3311 [ 74.002771][ T1] ### dt-test ### EXPECT_NOT / : ---[ end trace <<int>> ]--- [ 74.002782][ T1] ### dt-test ### EXPECT_NOT / : refcount_t: underflow; use-after-free. [ 74.004058][ T1] ### dt-test ### EXPECT_NOT / : WARNING: <<all>> [ 74.005510][ T1] ### dt-test ### EXPECT_NOT / : ------------[ cut here ]------------ [ 74.006757][ T1] ### dt-test ### pass of_unittest_lifecycle():3337 [ 74.009323][ T1] ### dt-test ### pass of_unittest_lifecycle():3338 Signed-off-by: Philip Li <philip.li@intel.com>

not look like a kernel issue which is part of torture testing. [ 598.791185][ T477] trivial-torture: torture_onoff begin holdoff [ 598.796769][ T482] trivial-torture: rcu_torture_read_exit: Start of test [ 598.797465][ T482] trivial-torture: rcu_torture_read_exit: Start of episode [ 598.883504][ T254] 2024-05-15 11:58:23 sleep 300 [ 598.883602][ T254] [ 603.808883][ T482] trivial-torture: rcu_torture_read_exit: End of episode [ 604.777893][ T463] ------------[ cut here ]------------ [ 604.779743][ T463] Modules linked in: rcutorture torture [ 604.782879][ T463] CPU: 1 PID: 463 Comm: rcu_torture_fak Tainted: G W N 6.9.0-05151-g1b294a1f3561 #1 [ 604.783893][ T463] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 [ 604.784992][ T463] RIP: 0010:synchronize_rcu_trivial+0xf8/0x150 [rcutorture] [ 604.785728][ T463] Code: 00 41 38 c4 7c 04 84 c0 75 3b 3b 1d 52 88 4c eb 0f 82 5c ff ff ff 48 83 c4 08 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc 90 <0f> 0b 90 eb a4 48 c7 c7 50 4e 4e 8b 48 89 55 d0 e8 53 a4 a1 e1 48 [ 604.787465][ T463] RSP: 0018:ffffc90001bcfe00 EFLAGS: 00210297 [ 604.788048][ T463] RAX: 0000000000000001 RBX: 0000000000000000 RCX: ffffffff81339381 [ 604.788810][ T463] RDX: 0000000000000002 RSI: 0000000000000004 RDI: ffff8881514bb168 [ 604.789557][ T463] RBP: ffffc90001bcfe30 R08: 0000000000000001 R09: ffffed102a29762d [ 604.790296][ T463] R10: ffff8881514bb16b R11: 0000000000000000 R12: 0000000000000003 [ 604.791050][ T463] R13: fffffbfff169c9ca R14: ffff8881514bb140 R15: dffffc0000000000 [ 604.791811][ T463] FS: 0000000000000000(0000) GS:ffff8883ae500000(0000) knlGS:0000000000000000 [ 604.792795][ T463] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 604.793420][ T463] CR2: 000000005679e39c CR3: 000000011c87c000 CR4: 00000000000406b0 [ 604.794169][ T463] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 604.795006][ T463] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 604.795766][ T463] Call Trace: [ 604.796092][ T463] <TASK> [ 604.796397][ T463] ? show_regs+0x5f/0x70 [ 604.796811][ T463] ? __warn+0xc7/0x3a0 [ 604.797210][ T463] ? synchronize_rcu_trivial+0xf8/0x150 [rcutorture] [ 604.797903][ T463] ? report_bug+0x274/0x2d0 [ 604.799211][ T463] ? handle_bug+0x7b/0xa0 [ 604.800055][ T463] ? exc_invalid_op+0x18/0x50 [ 604.800545][ T463] ? asm_exc_invalid_op+0x1b/0x20 [ 604.801036][ T463] ? sched_setaffinity+0xd1/0x430 [ 604.801521][ T463] ? synchronize_rcu_trivial+0xf8/0x150 [rcutorture] [ 604.802166][ T463] rcu_torture_fakewriter+0x22c/0x8c0 [rcutorture] [ 604.802827][ T463] ? __pfx_rcu_torture_fakewriter+0x10/0x10 [rcutorture] [ 604.803539][ T463] ? __kasan_check_read+0x11/0x20 [ 604.804064][ T463] ? __pfx_rcu_torture_fakewriter+0x10/0x10 [rcutorture] [ 604.804890][ T463] kthread+0x284/0x350 [ 604.822943][ T463] ? __pfx_kthread+0x10/0x10 [ 604.823463][ T463] ret_from_fork+0x38/0x80 [ 604.823915][ T463] ? __pfx_kthread+0x10/0x10 [ 604.824394][ T463] ret_from_fork_asm+0x1a/0x30 [ 604.824842][ T463] </TASK> [ 604.825121][ T463] irq event stamp: 9091 [ 604.825561][ T463] hardirqs last enabled at (9101): [<ffffffff814244ee>] console_unlock+0x19e/0x260 [ 604.826421][ T463] hardirqs last disabled at (9110): [<ffffffff814244d3>] console_unlock+0x183/0x260 [ 604.827337][ T463] softirqs last enabled at (9044): [<ffffffff8126c1bc>] handle_softirqs+0x4fc/0xa10 [ 604.828198][ T463] softirqs last disabled at (9039): [<ffffffff8126cac1>] irq_exit_rcu+0x81/0xb0 [ 604.829078][ T463] ---[ end trace 0000000000000000 ]--- [ 617.296437][ T482] trivial-torture: rcu_torture_read_exit: Start of episode [ 617.364556][ T482] trivial-torture: rcu_torture_read_exit: End of episode [ 628.799352][ T477] trivial-torture: torture_onoff end holdoff Signed-off-by: Philip Li <philip.li@intel.com>

/result/xfstests/4HDD-ext4-smbv2-generic-group-67/lkp-skl-d05/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3-func/gcc-13/v6.9/1$cat xfstests 2024-05-23 03:15:11 mount /dev/sda1 /fs/sda1 2024-05-23 03:15:12 mkdir -p /smbv2//cifs/sda1 2024-05-23 03:15:12 export FSTYP=cifs 2024-05-23 03:15:12 export TEST_DEV=//localhost/fs/sda1 2024-05-23 03:15:12 export TEST_DIR=/smbv2//cifs/sda1 2024-05-23 03:15:12 export CIFS_MOUNT_OPTIONS=-ousername=root,password=pass,noperm,vers=2.0,mfsymlinks,actimeo=0 2024-05-23 03:15:13 sed "s:^:generic/:" //lkp/benchmarks/xfstests/tests/generic-group-67 2024-05-23 03:15:13 ./check -E tests/cifs/exclude.incompatible-smb2.txt -E tests/cifs/exclude.very-slow.txt generic/676 generic/678 generic/679 FSTYP -- cifs PLATFORM -- Linux/x86_64 lkp-skl-d05 6.9.0 #1 SMP PREEMPT_DYNAMIC Wed May 22 12:10:20 CST 2024 generic/676 user :warn : [ 425.354191] run fstests generic/676 at 2024-05-23 03:16:38 user :notice: [ 6341.467686] generic/676 Thu May 23 04:55:14 UTC 2024 detected soft_timeout user :notice: [ 6341.747115] kill 1536 /usr/bin/time -v -o /tmp/lkp/xfstests.time /lkp/lkp/src/programs/xfstests/run user :err : [ 6341.760306] Terminated Signed-off-by: Philip Li <philip.li@intel.com>

Welcome to Debian GNU/Linux 11 (bullseye)! [ 40.060868][ T49] process 49 ((sd-executor)) attempted a POSIX timer syscall while CONFIG_POSIX_TIMERS is not set [ 40.066550][ T10] neighbour: Destroying alive neighbour (ptrval) [ 40.067510][ T10] CPU: 0 PID: 10 Comm: kworker/0:1 Tainted: G T 6.7.0-rc2-00145-gbc893f744ef0 #1 [ 40.068917][ T10] Workqueue: ipv6_addrconf addrconf_dad_work [ 40.069746][ T10] Call Trace: [ 40.070277][ T10] dump_stack_lvl+0x25/0x5f [ 40.070876][ T10] dump_stack+0xd/0x10 [ 40.071467][ T10] neigh_destroy+0x38/0xc3 [ 40.072036][ T10] neigh_release+0x19/0x1c [ 40.072583][ T10] ___neigh_create+0x3bd/0x3c9 [ 40.073164][ T10] __neigh_create+0x17/0x1c [ 40.073765][ T10] ip6_finish_output2+0x41b/0x4ff [ 40.074452][ T10] ? ip6_mtu+0x82/0x88 [ 40.074965][ T10] ip6_finish_output+0x178/0x199 [ 40.075737][ T10] ip6_output+0xc0/0xc7 [ 40.076282][ T10] dst_output+0x38/0x3e [ 40.076832][ T10] mld_sendpack+0x1f5/0x2b0 [ 40.077450][ T10] mld_send_initial_cr+0xdb/0xe3 [ 40.078144][ T10] ipv6_mc_dad_complete+0x2c/0x4c [ 40.078805][ T10] addrconf_dad_completed+0x127/0x286 [ 40.079460][ T10] addrconf_dad_work+0x2e7/0x368 [ 40.080104][ T10] process_one_work+0x1ba/0x2db [ 40.080724][ T10] process_scheduled_works+0x33/0x3a [ 40.081415][ T10] worker_thread+0x17c/0x1d4 [ 40.082017][ T10] ? __kthread_parkme+0x3a/0x76 [ 40.082694][ T10] kthread+0xcf/0xd4 [ 40.083209][ T10] ? create_worker+0x1b5/0x1b5 [ 40.083798][ T10] ? kthread_complete_and_exit+0x1b/0x1b [ 40.084510][ T10] ret_from_fork+0x1e/0x31 [ 40.085092][ T10] ? kthread_complete_and_exit+0x1b/0x1b [ 40.085791][ T10] ret_from_fork_asm+0x12/0x20 [ 40.086446][ T10] entry_INT80_32+0xef/0xef [ 40.722767][ T45] neighbour: Destroying alive neighbour (ptrval) [ 40.723678][ T45] CPU: 0 PID: 45 Comm: kworker/0:2 Tainted: G T 6.7.0-rc2-00145-gbc893f744ef0 #1 [ 40.725052][ T45] Workqueue: mld mld_dad_work [ 40.725679][ T45] Call Trace: [ 40.726208][ T45] dump_stack_lvl+0x25/0x5f Signed-off-by: Philip Li <philip.li@intel.com>

The change is safe even the patch is not finally in mainline. commit a66d4c29eca7e41cc457abd1e65a5261336c91b3 (linux-review/Muhammad-Usama-Anjum/selftests-firmware-conform-test-to-TAP/20240521-014314) Date: Mon May 20 09:37:57 2024 -0700 selftests: firmware: conform test to TAP Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Without using TAP messages, the passed/failed/skip test names cannot be found. This is a prepartory patch, more patches will be sent to comform the test completely. # # ----------------------------------------------------- # # Running kernel configuration test 1 -- rare # # Emulates: # # CONFIG_FW_LOADER=y # # CONFIG_FW_LOADER_USER_HELPER=n # # CONFIG_FW_LOADER_USER_HELPER_FALLBACK=n # ./fw_filesystem.sh: filesystem loading works # ./fw_filesystem.sh: async filesystem loading works # ./fw_filesystem.sh: firmware loading: platform trigger not present, ignoring test # # Testing with the file present... # Batched request_firmware() normal try #1: OK # Batched request_firmware() normal try #2: OK Signed-off-by: Philip Li <philip.li@intel.com>

[ 39.985634][ T1232] sysfs: cannot create duplicate filename '/devices/virtual/misc/btrfs-control' [ 39.994497][ T1232] CPU: 2 PID: 1232 Comm: modprobe Not tainted 6.9.0-rc5-00014-g691a646007c8 #1 [ 40.003251][ T1232] Hardware name: Dell Inc. OptiPlex 7040/0Y7WYT, BIOS 1.2.8 01/26/2016 [ 40.011306][ T1232] Call Trace: [ 40.014448][ T1232] <TASK> [ 40.017232][ T1232] dump_stack_lvl+0x53/0x70 [ 40.021572][ T1232] sysfs_warn_dup+0x75/0x90 [ 40.025915][ T1232] sysfs_create_dir_ns+0x208/0x280 [ 40.030860][ T1232] ? __pfx_sysfs_create_dir_ns+0x10/0x10 [ 40.036316][ T1232] ? _raw_spin_lock+0x85/0xe0 [ 40.040825][ T1232] kobject_add_internal+0x272/0x890 [ 40.045848][ T1232] kobject_add+0x13b/0x200 [ 40.050093][ T1232] ? __pfx_kobject_add+0x10/0x10 [ 40.054858][ T1232] ? __pfx_mutex_unlock+0x10/0x10 [ 40.059707][ T1232] ? kobject_get+0x50/0xe0 [ 40.063957][ T1232] ? kobject_put+0x50/0xd0 [ 40.068204][ T1232] device_add+0x218/0x1220 [ 40.072452][ T1232] ? __pfx_device_add+0x10/0x10 [ 40.077130][ T1232] device_create_groups_vargs+0x1be/0x230 [ 40.082672][ T1232] device_create_with_groups+0xab/0xe0 [ 40.087954][ T1232] ? __pfx_device_create_with_groups+0x10/0x10 [ 40.093928][ T1232] ? mutex_lock+0xa2/0xf0 [ 40.098087][ T1232] ? __pfx_mutex_lock+0x10/0x10 [ 40.102768][ T1232] ? __kmem_cache_create+0x37/0x60 [ 40.107706][ T1232] misc_register+0x1d3/0x680 [ 40.112127][ T1232] init_btrfs_fs+0xa6/0x260 [btrfs] [ 40.117243][ T1232] ? __pfx_init_btrfs_fs+0x10/0x10 [btrfs] [ 40.122961][ T1232] do_one_initcall+0xa4/0x3a0 [ 40.127467][ T1232] ? __pfx_do_one_initcall+0x10/0x10 [ 40.132579][ T1232] ? kasan_unpoison+0x44/0x70 [ 40.137085][ T1232] do_init_module+0x238/0x740 [ 40.141592][ T1232] init_module_from_file+0xd1/0x130 [ 40.146615][ T1232] ? __pfx_init_module_from_file+0x10/0x10 [ 40.152240][ T1232] ? __pfx_userfaultfd_unmap_complete+0x10/0x10 [ 40.158299][ T1232] ? __pfx__raw_spin_lock+0x10/0x10 [ 40.163322][ T1232] idempotent_init_module+0x23b/0x650 [ 40.168528][ T1232] ? __pfx_idempotent_init_module+0x10/0x10 [ 40.174242][ T1232] ? __fget_light+0x57/0x410 [ 40.178658][ T1232] ? security_capable+0x71/0xb0 [ 40.183336][ T1232] __x64_sys_finit_module+0xbe/0x130 [ 40.188444][ T1232] do_syscall_64+0x60/0x170 [ 40.192776][ T1232] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 40.198489][ T1232] RIP: 0033:0x7f9fa5393719 [ 40.202734][ T1232] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <4 8> 3d 01 f0 ff ff 73 01 c3 48 8b 0d b7 06 0d 00 f7 d8 64 89 01 48 [ 40.222079][ T1232] RSP: 002b:00007ffc7c8a5248 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 40.230297][ T1232] RAX: ffffffffffffffda RBX: 000056051ac7bd60 RCX: 00007f9fa5393719 [ 40.238078][ T1232] RDX: 0000000000000000 RSI: 00005604e7f1a4a0 RDI: 0000000000000000 [ 40.245873][ T1232] RBP: 00005604e7f1a4a0 R08: 0000000000000000 R09: 000056051ac7ec60 [ 40.253667][ T1232] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000040000 [ 40.261462][ T1232] R13: 0000000000000000 R14: 000056051ac7c030 R15: 0000000000000000 [ 40.269260][ T1232] </TASK> [ 40.272161][ T1232] kobject: kobject_add_internal failed for btrfs-control with -EEXIST, don't try to register things with the same name in the same direc tory. [ 40.601753][ T1231] request_module fs-btrfs succeeded, but still no fs? Link: https://lore.kernel.org/oe-lkp/202405291031.54c11515-oliver.sang@intel.com Signed-off-by: Philip Li <philip.li@intel.com>

For btrfs, /result/xfstests/4HDD-btrfs-generic-scratch-reflink-15/lkp-skl-d02/debian-12-x86_64-20240206.cgz/x86_64-rhel-8.3-func/gcc-13/v6.10-rc2/0 2024-06-11 10:49:19 export TEST_DIR=/fs/sdb1 2024-06-11 10:49:19 export TEST_DEV=/dev/sdb1 2024-06-11 10:49:19 export FSTYP=btrfs 2024-06-11 10:49:19 export SCRATCH_MNT=/fs/scratch 2024-06-11 10:49:19 mkdir /fs/scratch -p 2024-06-11 10:49:19 export SCRATCH_DEV_POOL="/dev/sdb2 /dev/sdb3 /dev/sdb4" 2024-06-11 10:49:19 export MKFS_OPTIONS="-mreflink=1 " 2024-06-11 10:49:19 sed "s:^:generic/:" //lkp/benchmarks/xfstests/tests/generic-scratch-reflink-15 2024-06-11 10:49:19 ./check generic/301 generic/302 IPMI BMC is not supported on this machine, skip bmc-watchdog setup! FSTYP -- btrfs PLATFORM -- Linux/x86_64 lkp-skl-d02 6.10.0-rc2 #1 SMP PREEMPT_DYNAMIC Mon Jun 3 11:25:48 CST 2024 MKFS_OPTIONS -- -mreflink=1 /dev/sdb2 MOUNT_OPTIONS -- /dev/sdb2 /fs/scratch our local _scratch_mkfs routine ... ERROR: unknown metadata profile reflink=1 check: failed to mkfs $SCRATCH_DEV using specified options Interrupted! Signed-off-by: Philip Li <philip.li@intel.com>

liuhangbin added 2 commits April 26, 2017 10:55

distro/adaptation: sort all dependences by alphabet

cadcdf6

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

distro/adaptation: remove duplicate lines and blanks at the end of line

5b72e47

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

rli9 merged commit e605c33 into intel:master Apr 26, 2017

This was referenced Aug 5, 2019

PACKERDRILL:Compilation Error #45

Closed

NVML:Compilation error with clang compiler #46

Closed

PIGLIT:Compilation error #47

Closed

Ankita-020696 mentioned this pull request Jul 13, 2020

Perf compile fails due to missing files #70

Closed

Ankita-020696 mentioned this pull request Jul 21, 2020

isn't a atomic jobfile, only atomic jobfile is supported #72

Closed

gongwuchun mentioned this pull request Dec 1, 2022

netperf: add riscv64 support #195

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

distro/adaptation: sort and remove duplicate lines #1

distro/adaptation: sort and remove duplicate lines #1

liuhangbin commented Apr 26, 2017

rli9 commented Apr 26, 2017

distro/adaptation: sort and remove duplicate lines #1

distro/adaptation: sort and remove duplicate lines #1

Conversation

liuhangbin commented Apr 26, 2017

rli9 commented Apr 26, 2017