[Finetune] use base model mpt-7b instead of mpt-7b-chat #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: minmingzhu <minming.zhu@intel.com>
Signed-off-by: minmingzhu <minming.zhu@intel.com>
carsonwang
reviewed
Apr 9, 2024
Comment on lines
+158
to
+161
| if config["General"].get("tokenizer_name") is not None: | ||
| tokenizer_name = config["General"].get("tokenizer_name") | ||
| else: | ||
| tokenizer_name = base_model |
There was a problem hiding this comment.
Suggested change
| if config["General"].get("tokenizer_name") is not None: | |
| tokenizer_name = config["General"].get("tokenizer_name") | |
| else: | |
| tokenizer_name = base_model | |
| tokenizer_name = config["General"].get("tokenizer_name", base_model) |
There was a problem hiding this comment.
If the 'tokenizer_name' is not specified in the config YAML, the expression config["General"].get("tokenizer_name") will return None instead of the expected default value 'base_model'. I plan to submit a pull request to address this issue.
Signed-off-by: minmingzhu <minming.zhu@intel.com>
carsonwang
approved these changes
Apr 10, 2024
minmingzhu
added a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
Apr 11, 2024
* use base model mpt-7b instead of mpt-7b-chat Signed-off-by: minmingzhu <minming.zhu@intel.com> * manual setting specify tokenizer Signed-off-by: minmingzhu <minming.zhu@intel.com> * update Signed-off-by: minmingzhu <minming.zhu@intel.com> * update doc/finetune_parameters.md Signed-off-by: minmingzhu <minming.zhu@intel.com> --------- Signed-off-by: minmingzhu <minming.zhu@intel.com>
minmingzhu
added a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
Apr 22, 2024
* use base model mpt-7b instead of mpt-7b-chat Signed-off-by: minmingzhu <minming.zhu@intel.com> * manual setting specify tokenizer Signed-off-by: minmingzhu <minming.zhu@intel.com> * update Signed-off-by: minmingzhu <minming.zhu@intel.com> * update doc/finetune_parameters.md Signed-off-by: minmingzhu <minming.zhu@intel.com> --------- Signed-off-by: minmingzhu <minming.zhu@intel.com>
minmingzhu
added a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
May 6, 2024
* use base model mpt-7b instead of mpt-7b-chat Signed-off-by: minmingzhu <minming.zhu@intel.com> * manual setting specify tokenizer Signed-off-by: minmingzhu <minming.zhu@intel.com> * update Signed-off-by: minmingzhu <minming.zhu@intel.com> * update doc/finetune_parameters.md Signed-off-by: minmingzhu <minming.zhu@intel.com> --------- Signed-off-by: minmingzhu <minming.zhu@intel.com>
minmingzhu
added a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
May 9, 2024
* use base model mpt-7b instead of mpt-7b-chat Signed-off-by: minmingzhu <minming.zhu@intel.com> * manual setting specify tokenizer Signed-off-by: minmingzhu <minming.zhu@intel.com> * update Signed-off-by: minmingzhu <minming.zhu@intel.com> * update doc/finetune_parameters.md Signed-off-by: minmingzhu <minming.zhu@intel.com> --------- Signed-off-by: minmingzhu <minming.zhu@intel.com>
minmingzhu
added a commit
to minmingzhu/llm-on-ray
that referenced
this pull request
May 16, 2024
* use base model mpt-7b instead of mpt-7b-chat Signed-off-by: minmingzhu <minming.zhu@intel.com> * manual setting specify tokenizer Signed-off-by: minmingzhu <minming.zhu@intel.com> * update Signed-off-by: minmingzhu <minming.zhu@intel.com> * update doc/finetune_parameters.md Signed-off-by: minmingzhu <minming.zhu@intel.com> --------- Signed-off-by: minmingzhu <minming.zhu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.