-
Notifications
You must be signed in to change notification settings - Fork 700
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SYCL] Remove broken atomic_memory_order* tests (#783)
Removes `atomic_memory_order*` tests, which are broken. They are using the pattern: ``` auto ld = aar.load(); ld += 1; aar.store(ld); ``` and checking if the whole sequence of operations is atomic. Which it is not - only each of the operations (load/store) on its own is atomic. Before #4853 was merged no backend supported acquire release or sequentially consistent memory orders, so these tests were never run before. This issue was first discussed here: #4853 (comment)
- Loading branch information
Showing
10 changed files
with
1 addition
and
457 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
53 changes: 0 additions & 53 deletions
53
SYCL/AtomicRef/atomic_memory_order_acq_rel_atomic64_generic.cpp
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.