Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Bump tag to 534071e52f84bad1dd7fb210a360414507f3b3ae #11880

Merged

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Nov 14, 2023

Pulls in the following fixes to the CUDA and HIP adapters:

  • [HIP] Correctly set HIP Kernel Buffer Arguments
  • [HIP] Fix host/device synchronization
  • [HIP][CTS] Fix Device CTS failures
  • [HIP] Fix get mem size segfault
  • [HIP] Implement urMemImageGetInfo
  • [HIP] Define all UR entry points
  • [CUDA] Add support for binary type query
  • [CUDA] Update hint functions to only return warnings instead of errors

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that oneapi-src/unified-runtime#1077 is merged, please pull in the latest sycl branch changes and update UNIFIED_RUNTIME_REPO and UNIFIED_RUNTIME_TAG as suggested. Update the title/description and make this PR ready for review.

sycl/plugins/unified_runtime/CMakeLists.txt Outdated Show resolved Hide resolved
@fabiomestre fabiomestre changed the title [UR] Update UR revision to [CUDA REV] [UR] Bump tag to 534071e52f84bad1dd7fb210a360414507f3b3ae Nov 15, 2023
@fabiomestre fabiomestre marked this pull request as ready for review November 15, 2023 11:33
@fabiomestre fabiomestre requested a review from a team as a code owner November 15, 2023 11:33
@kbenzie kbenzie force-pushed the fabio/combined_fixes_cuda_hip branch from f135561 to f70b4d2 Compare November 16, 2023 09:57
@kbenzie
Copy link
Contributor

kbenzie commented Nov 16, 2023

@intel/llvm-gatekeepers this is repeatedly failing on the Windows L0 E2E job, I believe this is a known issue. We intend this patch for the next release, could we get this merged?

@kbenzie
Copy link
Contributor

kbenzie commented Nov 17, 2023

@intel/llvm-gatekeepers please merge.

@aelovikov-intel aelovikov-intel merged commit 207d5e7 into intel:sycl Nov 17, 2023
12 checks passed
kbenzie pushed a commit to kbenzie/llvm that referenced this pull request Dec 15, 2023
Pulls in the following fixes to the CUDA and HIP adapters:

* [HIP] Correctly set HIP Kernel Buffer Arguments 
* [HIP] Fix host/device synchronization 
* [HIP][CTS] Fix Device CTS failures 
* [HIP] Fix get mem size segfault 
* [HIP] Implement urMemImageGetInfo
* [HIP] Define all UR entry points
* [CUDA] Add support for binary type query
* [CUDA] Update hint functions to only return warnings instead of errors
callumfare pushed a commit to kbenzie/llvm that referenced this pull request Dec 18, 2023
Pulls in the following fixes to the CUDA and HIP adapters:

* [HIP] Correctly set HIP Kernel Buffer Arguments 
* [HIP] Fix host/device synchronization 
* [HIP][CTS] Fix Device CTS failures 
* [HIP] Fix get mem size segfault 
* [HIP] Implement urMemImageGetInfo
* [HIP] Define all UR entry points
* [CUDA] Add support for binary type query
* [CUDA] Update hint functions to only return warnings instead of errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants