[Driver][SYCL][NewOffloadModel] Improve arch association for device #13898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the new offloading model, the values being passed to -fsycl-targets were not fully being realized when attempting to target specific architectures. Uses of -fsycl-targets=intel_gpu_* were not properly setting the arch values that are used down the line (namely the packaging step). Improve this situation by populating the assocated architecture mappings with what is seen when parsing the -fsycl-targets option. This applies to all intel_gpu, nvidia_gpu and amd_gpu targets.
mdtoguchi
force-pushed
the
set-arch-new-offload
branch
from
2d22e3f
to
1622e6f
Compare
hchilama
approved these changes
May 24, 2024
|
@intel/llvm-gatekeepers, this looks ready to merge - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new offloading model, the values being passed to -fsycl-targets were not fully being realized when attempting to target specific architectures. Uses of -fsycl-targets=intel_gpu_* were not properly setting the arch values that are used down the line (namely the packaging step).
Improve this situation by populating the assocated architecture mappings with what is seen when parsing the -fsycl-targets option. This applies to all intel_gpu, nvidia_gpu and amd_gpu targets.