[Driver][SYCL] Allow for SYCL defaultlibs to be added with clang-cl #13906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were restricting the SYCL defaultlibs from being added to the link command line when using clang-cl, even when -fsycl is added on the command line. Allow for these to be added to the link, as -fsycl implies the need for them.
hchilama
approved these changes
May 24, 2024
|
Testing has shown we do not want to add any libraries to the link command when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were restricting the SYCL defaultlibs from being added to the link command line when using clang-cl, even when -fsycl is added on the command line. Allow for these to be added to the link, as -fsycl implies the need for them.