[SYCL] Enable algorithm support for sub_group #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pennycook
added
the
spec extension
bader
reviewed
Mar 26, 2020
Signed-off-by: John Pennycook <john.pennycook@intel.com>
- sub_group member functions marked deprecated, to be removed later. - SPIR-V helpers expanded to convert SYCL group to SPIR-V scope. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Multiple definition errors again... Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Takes message as a string. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
force-pushed
the
sub-group-algorithms-prototype
branch
from
8c7725e
to
38f2906
Compare
Signed-off-by: John Pennycook <john.pennycook@intel.com>
bader
reviewed
Mar 27, 2020
| EnableIfIsScalarArithmetic<T> reduce(T x, T init, BinaryOperation op) const { | ||
| return op(init, reduce(x, op)); | ||
| } | ||
|
|
||
| template <typename T, class BinaryOperation> | ||
| #if __cplusplus >= 201402L |
There was a problem hiding this comment.
You don't need this #if anymore.
There was a problem hiding this comment.
Other than this small clean-up, the patch looks good to me.
There was a problem hiding this comment.
Oh, you're right. Thanks!
Signed-off-by: John Pennycook <john.pennycook@intel.com>
bader
approved these changes
Mar 27, 2020
aelovikov-intel
pushed a commit
that referenced
this pull request
Feb 17, 2023
This test store the matrix B that is VNNIed (packed) in a row major fashion. This is expected to fail on the GPU because the implementation does not support automatic transformation YET, in this case: VNNI to row major in the store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Pennycook john.pennycook@intel.com