[SYCL][CUDA][HIP] Report every device in its own platform #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CUDA and HIP plugins don't currently support having multiple devices in the same context, therefore this patch re-works the platform creation to place each device in its own platform to represent that. This should be changed back when multi-device support is added later on.
bader
added
cuda
smaslov-intel
approved these changes
Sep 14, 2021
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Sep 18, 2021
* upstream/sycl: (36 commits) [SYCL] Add SYCL2020 target::device enumeration value (intel#4587) [SYCL][Doc] Update ITT instrumentation docs (intel#4503) [SYCL][L0] Make all L0 events have device-visibility (intel#4534) [SYCL] Updated Level-Zero backend spec according to SYCL 2020 standard (intel#4560) [SYCL] Add error_code support for SYCL 1.2.1 exception classes (intel#4574) [SYCL][CI] Provide --ci-defaults option for config script (intel#4583) [CI] Switch GitHub Actions to Ubuntu 20.04 (intel#4582) [SYCL][CUDA] Fix context clearing in PiCuda tests (intel#4483) [SYCL] Hide SYCL service kernels (intel#4519) [SYCL][L0] Fix mismatched ZE call count (intel#4559) [SYCL] Remove function pointers extension (intel#4459) [GitHub Actions] Uplift clang version in post-commit validation (intel#4581) [SYCL] Ignore usm prefetch dummy flag (intel#4568) [SYCL][Group algorithms] Add group sorting algorithms implementation (intel#4439) [SYCL] Resolve name clash with a user defined symbol (intel#4570) [clang-offload-wrapper] Do not create .tgtimg section with -emit-reg-funcs=0 (intel#4577) [SYCL][FPGA] Remove deprecated attribute functionality (intel#4532) [SYCL] Remove _class aliases (intel#4465) [SYCL][CUDA][HIP] Report every device in its own platform (intel#4571) [SYCL][L0] make_device shouldn't need platform as an input (intel#4561) ...
npmiller
added a commit
to npmiller/llvm
that referenced
this pull request
Jan 17, 2022
This fixes the `USM/pointer_query.cpp` test from `llvm-test-suite` for HIP. For HIP the code was using the device pointer to index the device array for some reason, which is obviously incorrect, now it should be using the correct property to get the device index on the hardware. In addition for both HIP and CUDA the query was using the device index to index into the array of devices on the platform, this is incorrect since intel#4571 which moved every device in its own platform. Therefore to get the correct device we now need to use the index on the list of platforms, and then `0` on the list of devices.
bader
pushed a commit
that referenced
this pull request
Jan 18, 2022
This fixes the `USM/pointer_query.cpp` test from `llvm-test-suite` for HIP. For HIP the code was using the device pointer to index the device array for some reason, which is obviously incorrect, now it should be using the correct property to get the device index on the hardware. In addition for both HIP and CUDA the query was using the device index to index into the array of devices on the platform, this is incorrect since #4571 which moved every device in its own platform. Therefore to get the correct device we now need to use the index on the list of platforms, and then `0` on the list of devices.
t4c1
added a commit
to t4c1/llvm
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CUDA and HIP plugins don't currently support having multiple devices
in the same context, therefore this patch re-works the platform creation
to place each device in its own platform to represent that.
This should be changed back when multi-device support is added later on.
This fixes #4541 as suggested by @romanovvlad