[SYCL] Add property list to stream #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add a constructor to the SYCL 2020 stream class taking a property list argument. Additionally it adds the common property interface to the stream class. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
commented
Nov 4, 2021
| _ZNK2cl4sycl6device8get_infoILNS0_4info6deviceE131072EEENS3_12param_traitsIS4_XT_EE11return_typeEv | ||
| _ZNK2cl4sycl6device8get_infoILNS0_4info6deviceE131075EEENS3_12param_traitsIS4_XT_EE11return_typeEv | ||
| _ZNK2cl4sycl6device8get_infoILNS0_4info6deviceE131074EEENS3_12param_traitsIS4_XT_EE11return_typeEv | ||
| _ZNK2cl4sycl6device8get_infoILNS0_4info6deviceE131073EEENS3_12param_traitsIS4_XT_EE11return_typeEv |
There was a problem hiding this comment.
Note: The symbol-checker moved these further up. They have not been removed.
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
againull
previously approved these changes
Nov 12, 2021
|
@steffenlarsen there is some merge conflict appeared which blocks the merging, can you please resolve it? |
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
againull
previously approved these changes
Nov 12, 2021
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
|
@againull / @mlychkov / @sergey-semenov - Friendly ping on review. |
|
LGTM. But it'd be nice to get approve from RT team also. |
sergey-semenov
previously approved these changes
Dec 8, 2021
againull
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a constructor to the SYCL 2020 stream class taking a property list argument. Additionally it adds the common property interface to the stream class.