Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][CUDA] Disable by default the Image support #5256

Merged
merged 6 commits into from Jan 18, 2022

Conversation

pgorlani
Copy link
Contributor

@pgorlani pgorlani commented Jan 3, 2022

due to the fact that its actual CUDA implementation is partial.

It is possible to re-enable it by setting PI_CUDA_ENABLE_IMAGE_SUPPORT environment variable at runtime.

due to the fact that its actual CUDA implementation is partial.
It is possible to re-enable it by setting PI_CUDA_ENABLE_IMAGE_SUPPORT
environment variable at runtime.
@pgorlani pgorlani requested a review from a team as a code owner January 3, 2022 18:21
pgorlani added a commit to pgorlani/llvm-test-suite that referenced this pull request Jan 3, 2022
…sts.

This allows to run Image tests currently supported by the CUDA BE
even if the Image support is disabled by default.

This follows intel/llvm#5256
@pgorlani
Copy link
Contributor Author

pgorlani commented Jan 3, 2022

intel/llvm-test-suite#702 sets PI_CUDA_ENABLE_IMAGE_SUPPORT in order to run the Image tests supported by the CUDA BE.

smaslov-intel
smaslov-intel previously approved these changes Jan 3, 2022
sycl/plugins/cuda/pi_cuda.cpp Outdated Show resolved Hide resolved
sycl/plugins/cuda/pi_cuda.cpp Outdated Show resolved Hide resolved
sycl/plugins/cuda/pi_cuda.cpp Outdated Show resolved Hide resolved
pgorlani and others added 3 commits January 10, 2022 13:34
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
@pgorlani pgorlani requested a review from a team as a code owner January 10, 2022 14:41
pgorlani and others added 2 commits January 10, 2022 14:44
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

pgorlani added a commit to pgorlani/llvm-test-suite that referenced this pull request Jan 10, 2022
vladimirlaz pushed a commit to intel/llvm-test-suite that referenced this pull request Jan 18, 2022
…sts (#702)

This allows to run Image tests currently supported by the CUDA BE
even if the Image support is disabled by default.

This follows intel/llvm#5256
@vladimirlaz
Copy link
Contributor

The intel/llvm-test-suite#702 has been merged. This PR can be merged

@bader bader merged commit 90c8f05 into intel:sycl Jan 18, 2022
aelovikov-intel pushed a commit that referenced this pull request Feb 17, 2023
…sts (#702)

This allows to run Image tests currently supported by the CUDA BE
even if the Image support is disabled by default.

This follows #5256
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
…sts (intel#702)

This allows to run Image tests currently supported by the CUDA BE
even if the Image support is disabled by default.

This follows intel#5256
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…sts (intel/llvm-test-suite#702)

This allows to run Image tests currently supported by the CUDA BE
even if the Image support is disabled by default.

This follows intel#5256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants