New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][CUDA] Disable by default the Image support #5256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to the fact that its actual CUDA implementation is partial. It is possible to re-enable it by setting PI_CUDA_ENABLE_IMAGE_SUPPORT environment variable at runtime.
pgorlani
added a commit
to pgorlani/llvm-test-suite
that referenced
this pull request
Jan 3, 2022
…sts. This allows to run Image tests currently supported by the CUDA BE even if the Image support is disabled by default. This follows intel/llvm#5256
intel/llvm-test-suite#702 sets PI_CUDA_ENABLE_IMAGE_SUPPORT in order to run the Image tests supported by the CUDA BE. |
smaslov-intel
previously approved these changes
Jan 3, 2022
bader
reviewed
Jan 10, 2022
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
…NABLE_IMAGE_SUPPORT' documentation
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
bader
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
pgorlani
added a commit
to pgorlani/llvm-test-suite
that referenced
this pull request
Jan 10, 2022
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jan 18, 2022
…sts (#702) This allows to run Image tests currently supported by the CUDA BE even if the Image support is disabled by default. This follows intel/llvm#5256
The intel/llvm-test-suite#702 has been merged. This PR can be merged |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
…sts (intel#702) This allows to run Image tests currently supported by the CUDA BE even if the Image support is disabled by default. This follows intel#5256
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…sts (intel/llvm-test-suite#702) This allows to run Image tests currently supported by the CUDA BE even if the Image support is disabled by default. This follows intel#5256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to the fact that its actual CUDA implementation is partial.
It is possible to re-enable it by setting
PI_CUDA_ENABLE_IMAGE_SUPPORT
environment variable at runtime.