Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESIMD] Add esimd::merge free function. #5308
[ESIMD] Add esimd::merge free function. #5308
Changes from all commits
03aa218
1919364
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the usage of the mask here consistent with the other two overloads?
The first two use
a.merge(b, m)
, and the documentation says "The semantic is that if the LSB of an element of Mask is set, then the corresponding data element of Val is copied to the corresponding position in the calling simd object." --b
is copied ifm
is true.This one uses
merge(a, b, m)
, and the documentation says "The semantic is that if the LSB of an element of Mask is set, then the corresponding data element of Val1 is copied to the corresponding position in the calling simd object".Am I reading the documentation wrong, or should this be
merge(b, a, m)
to match the semantics?(A simpler way to ask the same question might be: is the behavior of this two-input version of
merge
the same as the two-input member function?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch of this discrepancy in the documentation, John. The actual behavior is that any non-zero in a mask element (e.g. 0x8) is considered as "enabled", so this version is correct, and the one is not. I'm working on updating the documentation, so I will address this.
The behavior is consistent across all versions/overloads of merge, as those ones are implemented through the other.