[sycl-post-link][NewPM] Port passes execution for extracted submodule… #5337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into new PM Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
| // TODO: Use the new PassManager instead? | ||
| legacy::PassManager Passes; | ||
| ModuleAnalysisManager MAM; | ||
| MAM.registerPass([&] { return PassInstrumentationAnalysis(); }); |
There was a problem hiding this comment.
For the sake of my own education, could you please comment why this pass is needed?
There was a problem hiding this comment.
PassInstrumentationAnalysis pass is used by the new Pass Manager on each iteration over user specified passes.
So, it should be registered always.
Another option to register it is to call PassBuilder::registerModuleAnalyses(ModuleAnalysisManager &);
There was a problem hiding this comment.
I think that current variant is short enough, so we can leave it as-is. I just wanted to make sure that this is mandatory step
AlexeySachkov
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… into new PM
Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com