[SYCL][Doc] Kernel parameter attribute change in compile-time properties design doc #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies design doc This commit changes the use of `__sycl_detail__::add_ir_attributes_kernel_parameter` to be on `__init` parameters rather than member variables. This simplifies the propagation of the attribute as it is closer to how the frontend generates kernel function parameters. Additionally this commit makes some minor corrections. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
requested review from
gmlueck,
premanandrao and
elizabethandrews
elizabethandrews
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the use of
__sycl_detail__::add_ir_attributes_kernel_parameterto be on__initparameters rather than member variables. This simplifies the propagation of the attribute as it is closer to how the frontend generates kernel function parameters.Additionally these changes make some minor corrections.