[ESIMD] Doxygen update part I - fix structure, filter non-public APIs. #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
previously approved these changes
Jan 25, 2022
sycl/include/sycl/ext/intel/experimental/esimd/emu/detail/esimd_emulator_device_interface.hpp
Outdated
Show resolved
Hide resolved
bader
requested changes
Jan 26, 2022
alexbatashev
previously approved these changes
Jan 27, 2022
|
@sndmitriev, @kychendev - please take a look. Your approval is needed for merging. |
|
@bader - please take a look, your comments have been addressed. |
bader
previously approved these changes
Jan 27, 2022
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
…d_emulator_device_interface.hpp Co-authored-by: Alexander Batashev <alexbatashev@outlook.com>
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
kbobrovs
force-pushed
the
esimd_doxygen
branch
from
78f33c9
to
d8b046a
Compare
|
Had to rebase to reproduce and fix test failure. |
|
@sndmitriev, @kychendev - please take a look. Your approval is needed for merging. |
sndmitriev
approved these changes
Jan 28, 2022
|
@bader, @alexbatashev - please re-approve. Had to rebase and fix slm_init to fix test failure |
alexbatashev
approved these changes
Jan 28, 2022
|
@alexbatashev, thanks for approval. Could you merge? Alexey approved this already (approval just expired due to my rebase) |
|
@kbobrovs I can't, but @vladimirlaz can |
|
@alexbatashev - thanks, pinged Vladimir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Konstantin S Bobrovsky konstantin.s.bobrovsky@intel.com