New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Implement decorated enum class #5399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefinition of default constructor image_accessor() (previously used "= default") to make it possible to use const references in parallel_for.
Reduced ad hoc test file.
Fixed typo
Rewrite of RUN part.
Created new test for fixed issue with mismatched namespace for ctz function.
[SYCL]Created regression test for ctz fix
…ed_tests Revert "[SYCL]Created regression test for ctz fix"
Reduced test file so it contains only func() function, edited commented line for test running.
Edited commented line for testing, corrected typos in code.
Removed SYCL_EXTERNAL attribute due to it's unnecessity in this test (parallel_for is used here).
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
Added enum class sycl::access::decorated.
vladimirlaz
reviewed
Jan 26, 2022
Co-authored-by: vladimirlaz <vladimir.lazarev@intel.com>
vladimirlaz
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added enum class sycl::access::decorated to access.hpp, so it would be possible to perform tests demanding this implementation.