[SYCL] Fix SYCL Kernel Body Check #5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCLKernelAttr can be used to check if a given function is a SYCL kernel body function or not. A SYCL kernel body function is the operator() method of a SYCL Kernel Functor or Lamda Function. The existing check which only tested if a FunctionDecl was an operator or not, allowed for false positives. This patch adds an additional check for th SYCLKernelAttr, which will be attached to the kernel body function's parent/ parent's parent (for wrapped kernels) Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
Fznamznon
reviewed
Feb 11, 2022
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
smanna12
previously approved these changes
Feb 11, 2022
smanna12
reviewed
Feb 11, 2022
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
premanandrao
approved these changes
Feb 11, 2022
Fznamznon
approved these changes
Feb 14, 2022
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Feb 23, 2022
…/llvm into refactor_existing_workflows * 'refactor_existing_workflows' of github.com:alexbatashev/llvm: (2051 commits) [SYCL][L0] Honor property::queue::enable_profiling (intel#5543) [SYCL][CI] Enable sccache on Windows (intel#5589) [SYCL][Doc] Move internal design docs (intel#5556) [sycl-post-link] Initialize the integer Value variable (intel#5585) [CI] Fix nightly builds (intel#5584) [SYCL][L0] Fix use of copy-engines in L0 interop queue (intel#5579) Update OpenCL headers tag to dcd5bed (intel#5575) [SYCL] Fix warning for InOrderQueueSyncCheck unit test build (intel#5577) [SYCL][HIP] Remove arch requirement for running lit tests (intel#5253) [SYCL][L0] Fix timestamp calculation (in ns) (intel#5555) [SYCL] Fix sync of host task vs kernel for in-order queue (intel#5551) [sycl-post-link] Add a check for device globals with device_image_scope (intel#5517) [SYCL] Fix SYCL Kernel Body Check (intel#5546) [SYCL] Add support for SYCL 2020 in class group (intel#5447) Fix tests after 1c729d7 Use align attribute for kernel pointer arg alignment Fix tests after 18834dc Mark pointer-typed kernel arguments as ABI aligned [CI] Add experimental Windows build to GitHub Actions nightly (intel#5560) [sycl-post-link][NFC] Address clang-tidy concerns in the sycl-post-link (intel#5552) Fix lit test after changes in Clang Improve backward compatibility for DISubRange ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCLKernelAttr can be used to check if a given function is
a SYCL kernel body function or not. A SYCL kernel body function
is the operator() method of a SYCL Kernel Functor or Lambda Function.
The existing check which only tested if a FunctionDecl was an
operator or not, allowed for false positives. This patch adds an
additional check for SYCLKernelAttr, which will be attached to
the kernel body function's parent/ parent's parent (for wrapped
kernels)
Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com