Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD] Add support for named barrier APIs #5583

Merged
merged 2 commits into from Feb 20, 2022

Conversation

sndmitriev
Copy link
Contributor

Signed-off-by: Sergey Dmitriev serguei.n.dmitriev@intel.com

Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
mlychkov
mlychkov previously approved these changes Feb 16, 2022
Copy link
Contributor

@mlychkov mlychkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small nit LGTM.

llvm/lib/SYCLLowerIR/ESIMD/LowerESIMD.cpp Outdated Show resolved Hide resolved
Co-authored-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also don't forget to add an E2E test.

@sndmitriev
Copy link
Contributor Author

Errors on buildbot/Lit_With_Cuda look like an infrastructure problem.

@kbobrovs
Copy link
Contributor

@intel/dpcpp-tools-reviewers, ping

@kbobrovs kbobrovs merged commit 1df0038 into intel:sycl Feb 20, 2022
@sndmitriev sndmitriev deleted the sndmitriev/esimd-nbarriers branch February 21, 2022 03:39
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Feb 23, 2022
* upstream/sycl: (2757 commits)
  [SYCL][Doc] Fixing incorrect merge of community Readme.md with our version (intel#5636)
  [SYCL] Change USM pooling parameters. (intel#5457)
  [CI] Fix cache location on Windows (intel#5603)
  [SYCL][NFC] Fix a warning about uninitialized struct members (intel#5610)
  [Buildbot] Update Windows GPU version to 101.1340 (intel#5620)
  Fix SPIRV -> OCL barrier call argument attributes
  Move SPV_INTEL_memory_access_aliasing tokens from spirv_internal
  [SYCL][ESIMD] Add support for named barrier APIs (intel#5583)
  [SYCL][L0] Remove ZeModule when program build failed (intel#5541)
  [SYCL] Silence "unknown attribute" warning for `device_indirectly_callable` (intel#5591)
  [SYCL][DOC] Introductory material for extensions (intel#5605)
  [SYCL][DOC] Change extension names to lower case (intel#5607)
  [SYCL] Improve get_kernel_bundle performance (intel#5496)
  [SYCL] Do not build device code for sub-devices (intel#5240)
  [sycl-post-link] Fix a crash during spec-constant properties generation (intel#5538)
  [SYCL][DOC] Move SPIR-V and OpenCL extensions (intel#5578)
  [SYCL][ESIMD][EMU] Update memory intrinsics for ESIMD_EMU plugin (intel#4748)
  [CI] Allow stale issue bot to analyze more issues (intel#5602)
  [SYCL][L0] Honor property::queue::enable_profiling (intel#5543)
  [OpenMP] Properly save strings when doing LTO
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants