Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enable HIP/CUDA/ESIMD plugins in nightly build #9850

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[CI] Enable HIP/CUDA/ESIMD plugins in nightly build #9850

merged 1 commit into from
Jun 13, 2023

Conversation

aelovikov-intel
Copy link
Contributor

That is needed so that we could use the resulting image to test PRs that only touch SYCL End-to-End tests

@aelovikov-intel
[CI] Enable HIP/CUDA/ESIMD plugins in nightly build
159bd38 
That is needed so that we could use the resulting image to test PRs that
only touch SYCL End-to-End tests
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 13, 2023 17:32
stdale-intel
stdale-intel approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@stdale-intel stdale-intel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this is good to go. Has been reviewed and approved from up high (@jbrodman) in terms of any legal/other impact.

steffenlarsen
steffenlarsen approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@aelovikov-intel aelovikov-intel merged commit 6b74243 into intel:sycl Jun 13, 2023
13 of 14 checks passed
@aelovikov-intel aelovikov-intel deleted the nightly-more-plugins branch June 13, 2023 18:30
fineg74 pushed a commit to fineg74/llvm that referenced this pull request Jun 15, 2023
@aelovikov-intel @fineg74
[CI] Enable HIP/CUDA/ESIMD plugins in nightly build (intel#9850)
7798d83 
That is needed so that we could use the resulting image to test PRs that
only touch SYCL End-to-End tests
@npmiller
Copy link
Contributor

@aelovikov-intel it looks like the libpi_cuda.so and libpi_hip.so plugins are still not in the nightly tarball dpcpp-compiler.tar.gz here:

Is there something else that needs to be enabled?

@aelovikov-intel
Copy link
Contributor Author

@stdale-intel just told me yesterday about that location. Turns out these are created somewhere else and he's going to follow up on that.

@rafbiels rafbiels mentioned this pull request Jul 3, 2023
Closed
aelovikov-intel added a commit that referenced this pull request Jul 10, 2023
@aelovikov-intel
Revert "[CI] Enable HIP/CUDA/ESIMD plugins in nightly build (#9850)"
74ee69f 
This reverts commit 6b74243.

Needs adjustments in E2E-testing performed on the build as that has been
enabled since #9850.
@aelovikov-intel aelovikov-intel mentioned this pull request Jul 10, 2023
Merged
aelovikov-intel added a commit that referenced this pull request Jul 10, 2023
@aelovikov-intel
Revert "[CI] Enable HIP/CUDA/ESIMD plugins in nightly build (#9850)" (#…
5c10c73 
…10286)

This reverts commit 6b74243.

Needs adjustments in E2E-testing performed on the build as that has been
enabled since #9850. Also, disable E2E on nightly in pre-commit as that
requires an image with all plugins enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@stdale-intel stdale-intel stdale-intel approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aelovikov-intel @npmiller @steffenlarsen @stdale-intel