Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: verify rst documents with lint tool #160

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

dvrogozh
Copy link
Contributor

No description provided.

This patch fixes all rst-lint reported issues with level >= warning:
  WARNING ./doc/quality.rst:205 Blank line required after table.
  WARNING ./doc/quality-lowdelay.rst:180 Blank line required after table.
  WARNING ./doc/benchmarking.rst:2 Duplicate explicit target name: "performance".
  WARNING ./doc/benchmarking.rst:2 Duplicate explicit target name: "quality".
  WARNING ./doc/benchmarking.rst:2 Duplicate explicit target name: "performance".
  WARNING ./doc/benchmarking.rst:2 Duplicate explicit target name: "quality".
  WARNING ./doc/virtualization.rst:455 Bullet list ends without a blank line; unexpected unindent.
  WARNING ./doc/benchmarks/intel-data-center-gpu-flex-series/intel-data-center-gpu-flex-series.rst:2 Duplicate explicit target name: "22ww33_419.38_ubuntu514".

It also fixes some, but not all issues with level == info. Specifically,
"duplicate implicit target name" issues are not fixed if reported for
duplicated sub-headers.

It occurs that anonymous links should be given with `__` (2 underscores) in rst.
There is a reason however to leave non-anonymous links (`_`, i.e. 1 underscore)
where possible, which is everywhere except when we get an issue from rst-lint
that anonymous link is duplicated. Such cases got fixed in this change.

Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Copy link
Contributor

@dsocek dsocek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvrogozh dvrogozh merged commit 2049e5f into intel:master Apr 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants