Build error with stable libva

[pryg-skok]

I'm trying to build the newest but stable MediaSDK on ubuntu 16.04.4.
Based on wiki I've updated my compiler to gcc-6:

Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/6/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 6.4.0-17ubuntu1~16.04' --with-bugurl=file:///usr/share/doc/gcc-6/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --with-as=/usr/bin/x86_64-linux-gnu-as --with-ld=/usr/bin/x86_64-linux-gnu-ld --program-suffix=-6 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-6-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-6-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-6-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 6.4.0 20180424 (Ubuntu 6.4.0-17ubuntu1~16.04) 

Also on wiki I've read that I should use specific libva version:
git checkout tags/2.1.1.pre1-20180601

Next I've tried to build master commit of media_driver and it fails with error:

/root/media-driver/media_driver/linux/common/codec/ddi/media_ddi_decode_hevc.cpp:434:14: error: ‘VASubsetsParameterBufferType’ was not declared in this scope
         case VASubsetsParameterBufferType:
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/build.make:9782: recipe for target 'media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/linux/common/codec/ddi/media_ddi_decode_hevc.cpp.o' failed
make[2]: *** [media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/linux/common/codec/ddi/media_ddi_decode_hevc.cpp.o] Error 1
CMakeFiles/Makefile2:167: recipe for target 'media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/all' failed
make[1]: *** [media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/all] Error 2
Makefile:149: recipe for target 'all' failed

If I try to build the master version of libva there is another error:

/root/media-driver/media_driver/linux/common/ddi/media_libva_putsurface_linux.h:31:29: fatal error: va/va_dricommon.h: No such file or directory
 #include <va/va_dricommon.h>
                             ^
compilation terminated.
media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/build.make:10310: recipe for target 'media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/linux/common/ddi/media_libva.cpp.o' failed
make[2]: *** [media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/linux/common/ddi/media_libva.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:167: recipe for target 'media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/all' failed
make[1]: *** [media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/all] Error 2
Makefile:149: recipe for target 'all' failed

So, which commits should I use to successfully media-driver?

[pryg-skok]

Maybe I need to submit additional info about build environment?

[yangning1368]

Yes, Please give more detail or reproduce steps for your issue.
Thanks!

[XinfengZhang]

please help to check the version, libva add VASubsetsParameterBufferType recently, and driver also add it, so you need compatible libva version

[kwende]

Is there any further input on this? I'm getting this error too. I'm using the same branch as this guy.

Update: pulling master as of 4/12/2019 and using that instead of the particular tag mentioned worked for me. The media-driver built.

[michaelolbrich]

va/va_dricommon.h is only installed if libva ls build with -Dwith_x11=yes / --enable-x11. However the header is used here if X11_FOUND is defined. And this is defined if CMake found (some?) X11 libs and headers, regardless of the libva configuration.

So the missing include error can happen if the X11 devel packages are installed but libva is compiled with X11 support explicitly disabled.