Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug builds #1491

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix debug builds #1491

merged 1 commit into from
Feb 27, 2023

Conversation

stolk
Copy link
Contributor

@stolk stolk commented Sep 15, 2022

Both clang and gcc fail creating debug builds.

This fix addresses the following compile warnings/errors:

comparison of constant 8 with expression of type 'MHW_ROTATION' (aka '_MHW_ROTATION') is always true

pointer ‘oldPtr’ may be used after ‘void* realloc(void*, size_t)’

the address of ‘MOS_SURFACE::OsResource’ will never be NULL

This fixes issue #1490

@stolk stolk requested review from Xiaogangli-intel and removed request for XinfengZhang October 6, 2022 20:48
@stolk
Copy link
Contributor Author

stolk commented Oct 12, 2022

What's the verdict on this?

@hye5 hye5 requested a review from FurongZhang January 18, 2023 12:32
@hye5 hye5 mentioned this pull request Jan 18, 2023
Closed
@VickyZengg
Copy link
Contributor

What's the verdict on this?

Hi Stolk, can you help rebase this pr? It had conflict now.

@stolk
Copy link
Contributor Author

stolk commented Feb 22, 2023

What's the verdict on this?

Hi Stolk, can you help rebase this pr? It had conflict now.

Rebased.

FurongZhang
FurongZhang approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@FurongZhang FurongZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LhGu LhGu added the verifying PR: fix ready and verifying with build/test label Feb 27, 2023
@intel-mediadev intel-mediadev merged commit 29ff1a4 into intel:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jexu Jexu Jexu approved these changes

@FurongZhang FurongZhang FurongZhang approved these changes

@pingliwa pingliwa pingliwa approved these changes

@VickyZengg VickyZengg VickyZengg approved these changes

@LhGu LhGu LhGu approved these changes

@Xiaogangli-intel Xiaogangli-intel Awaiting requested review from Xiaogangli-intel

@XinfengZhang XinfengZhang Awaiting requested review from XinfengZhang XinfengZhang is a code owner

Assignees
No one assigned
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@stolk @VickyZengg @Jexu @FurongZhang @pingliwa @Xiaogangli-intel @LhGu @intel-mediadev