[ddi] Load libX11.so.6 instead of libX11.so #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libX11.so is a linker name so it is not available if the libX11-dev package is not installed. As a result, attempting to render to screen with X server will fail (e.g. sample_decode -r) This fix changes the code to dlopen the actual library name instead: libX11.so.6 The same patch has been applied to MediaSDK samples: Intel-Media-SDK/MediaSDK#210 And a similar issue was addressed in media-driver: intel#150
|
hi @jonrecker I am not sure whether it is correct. but on my machine , /usr/lib/libX11.so -> libX11.so.6.3.0 |
|
Yes, that is correct. Installing only the libX11 package will install the actual library libX11.so.6.3.0, and also create a symbolic link libX11.so.6 -> libX11.so.6.3.0.
Installing the developer package libX11-dev will install some additional components and create the link libX11.so -> libX11.so.6.3.0, which is used by the linker.
So currently if the user does not install libX11-dev, media-driver will fail to load because the link for libX11.so does not exist. This is the same basic problem which was addressed in issue #150
|
intel-mediadev
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libX11.so is a linker name so it is not available if the
libX11-dev package is not installed. As a result, attempting to
render to screen with X server will fail (e.g. sample_decode -r)
This fix changes the code to dlopen the actual library name
instead: libX11.so.6
The same patch has been applied to MediaSDK samples:
Intel-Media-SDK/MediaSDK#210
And a similar issue was addressed in media-driver:
#150