Add X11 detect support #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an updated version of the original PR intel#492 Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
dvrogozh
reviewed
Jan 16, 2019
| @@ -32,7 +32,7 @@ | |||
| #include <sys/ioctl.h> | |||
| #include <unistd.h> | |||
|
|
|||
| #ifndef ANDROID | |||
| #if !defined(ANDROID) && defined(X11_FOUND) | |||
There was a problem hiding this comment.
Shouldn't we use just:
#ifdef X11_FOUND
and assure that build system don't set this for Android path? Smaller number of defines and code, the better.
| @@ -176,6 +176,10 @@ set(MEDIA_COMPILER_FLAGS_DEBUG | |||
| -DINSTR_GTUNE_EXT | |||
| ) | |||
|
|
|||
| if(X11_FOUND) | |||
| add_definitions(-DX11_FOUND) | |||
There was a problem hiding this comment.
To me passing -DHAVE_X11=1 seems better since it is aligned with what people are accustomed to with autotools. In this case Android should explicitly set -DHAVE_X11=0 and checks below should look like:
#if HAVE_X11
|
What if someone will want to build the driver without X11? Are we going to provide a build option to disable X11 support? |
Sherry-Lin
approved these changes
Jan 16, 2019
azharsha
added a commit
to azharsha/media-driver
that referenced
this pull request
Jan 17, 2019
PR intel#494 set vaPutSurface as NULL, libva throws an error and iHD driver is not initialized. Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Merged
Sherry-Lin
pushed a commit
that referenced
this pull request
Jan 25, 2019
PR #494 set vaPutSurface as NULL, libva throws an error and iHD driver is not initialized. Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Sherry-Lin
pushed a commit
that referenced
this pull request
Jan 29, 2019
PR #494 set vaPutSurface as NULL, libva throws an error and iHD driver is not initialized. Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
djie1
pushed a commit
to djie1/media-driver
that referenced
this pull request
May 20, 2019
PR intel#494 set vaPutSurface as NULL, libva throws an error and iHD driver is not initialized. Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
dyang23
pushed a commit
to dyang23/media-driver-intel-
that referenced
this pull request
May 14, 2020
PR intel#494 set vaPutSurface as NULL, libva throws an error and iHD driver is not initialized. Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jul 3, 2021
Rebased patch 0001 and removed another hardening flag. Removed patch 0002 which was backported from upstream commit. Renumbered and rebased patch 0003. Reformatted hashes. Reworked X11 support as it is an optional dependency: intel/media-driver#494 Release notes: https://github.com/intel/media-driver/releases/tag/intel-media-21.2.3 Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of the original PR #492
Signed-off-by: Azhar Shaikh azhar.shaikh@intel.com